Review main Merged

68257[BUGFIX] FormEngine: Validate human-readable selectMultipleSideBySide field

Andreas Kienast CR +2 V +2 Easy +1 −0 updated 03/10/21, 17:01

Commit message

If a selectMultipleSideBySide field has a "minItems" constraint, the
wrong field gets validated which makes it impossible to store a record if
an affected field would fulfill the constraint after a change.

This patch adds an additional validation for the human-readable field.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Richard Haeser +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 1

Review log 610

  1. Andreas Kienast uploaded patch set 1 03/08/21, 21:12

  2. TYPO3com voted on patch set 1 V +1 03/08/21, 21:19 Completed build in 06m 45s on Mon, 8 Mar, 09:19 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9948

  3. core-ci voted on patch set 1 V +1 03/08/21, 21:21 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1293

  4. Markus Klein updated the commit message in patch set 2 03/08/21, 21:28

  5. Markus Klein voted on patch set 2 CR +1 03/08/21, 21:28

  6. TYPO3com voted on patch set 2 V +1 03/08/21, 21:36 Completed build in 07m 56s on Mon, 8 Mar, 09:36 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9949

  7. core-ci voted on patch set 2 V +1 03/08/21, 21:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1294

  8. Richard Haeser voted on patch set 2 V +1 CR +1 03/08/21, 21:44

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 03/10/21, 17:00

  10. Andreas Kienast merged patch set 3 03/10/21, 17:01