Review main Merged

68258[FEATURE] Possibility to disable canonical per page

Richard Haeser CR +2 V +2 Normal +62 −2 updated 03/22/21, 19:19

Commit message

If you have a good reason to disable the default rendering of
the canonical tag, you can now use a TypoScript setting.

To disable the canonical generation, you can add the following
line to your TypoScript setup.

.. code-block:: typoscript

   config.disableCanonical = 1

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Chris Müller +1
    • Oli Bartsch +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Chris Müller +1
    • Oli Bartsch +1
    • Guido Schmechel +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 5

Review log 1420

  1. Richard Haeser uploaded patch set 1 03/08/21, 21:31

  2. core-ci voted on patch set 1 V +1 03/08/21, 21:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1295

  3. TYPO3com voted on patch set 1 V +1 03/08/21, 21:43 Completed build in 11m 30s on Mon, 8 Mar, 09:43 PM Test Summary: 32640 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9950

  4. Guido Schmechel updated the commit message in patch set 2 03/10/21, 22:05

  5. Guido Schmechel commented on patch set 2 V +1 CR +1 03/10/21, 22:07

    Just changed a typo in the commit message. Patch is fine
  6. TYPO3com voted on patch set 2 V +1 03/10/21, 22:12 Completed build in 07m 06s on Wed, 10 Mar, 10:12 PM Test Summary: 32683 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10037

  7. core-ci voted on patch set 2 V +1 03/10/21, 22:15 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1398

  8. Markus Klein commented on patch set 2 03/12/21, 12:21

    CanonicalGenerator.php:61 Unresolved

    not sure if I understood correctly. The disable flag only works if NO href is generated?
  9. Guido Schmechel wrote 03/12/21, 12:31

    Removed Verified+1 by Guido Schmechel <guido.schmechel@brandung.de>
  10. Guido Schmechel wrote 03/12/21, 12:31

    Removed Code-Review+1 by Guido Schmechel <guido.schmechel@brandung.de>
  11. Richard Haeser uploaded patch set 3 03/15/21, 18:59

  12. TYPO3com voted on patch set 3 V +1 03/15/21, 19:06 Completed build in 07m 09s on Mon, 15 Mar, 07:06 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10143

  13. core-ci voted on patch set 3 V +1 03/15/21, 19:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1560

  14. Oli Bartsch commented on patch set 3 03/19/21, 09:49

    I wonder why we need a new TypoScript config when we already have an event. Isn't the main problem here, that the event is called at the top instead of being called after the core functionality took place?
  15. Richard Haeser commented on patch set 3 03/19/21, 10:05

    Reply

    The issue is that you want to have the possibility to easily exclude 1 or more pages. Ofcourse this is possible with the Event, but you have to create the code and maybe even typoscript settings yourselves. As more people want to have a possibility to easily disable the feature for one or more pages, I think it is good to have this by default in core. The Event is (currently) not ment to disable the canonical, just to set correct data. So it is not possible to use the Event (at the moment). Last thing is consistency. It is already possible to disable the hreflang by TypoScript. See https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/Setup/Config/Index.html#disablehreflang
  16. Oli Bartsch commented on patch set 3 V +1 CR +1 03/19/21, 16:23

    ACK
  17. Chris Müller voted on patch set 3 V +1 CR +1 03/19/21, 18:41

  18. Guido Schmechel voted on patch set 3 V +1 CR +1 03/20/21, 10:04

  19. Daniel Goerz voted on patch set 3 V +2 CR +2 03/22/21, 19:19

  20. Daniel Goerz merged patch set 4 03/22/21, 19:19