68293[TASK] Show otpauth URL next to shared secret
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Georg Ringer +2
- Benjamin Franzke +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/core/Resources/Public/TypeScript/Authentication/MfaProvider/Totp.tsnew+64 −0
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/TotpProvider.php+8 −8
- typo3/sysext/core/Resources/Private/Language/locallang_mfa_provider.xlf+20 −1
- typo3/sysext/core/Resources/Private/Templates/Authentication/MfaProvider/Totp/Setup.html2+24 −1
- typo3/sysext/core/Resources/Public/JavaScript/Authentication/MfaProvider/Totp.jsnew+16 −0
Review log 1731
Show 26 earlier messages
-
Oli Bartsch uploaded patch set 1 03/09/21, 11:21
-
TYPO3com voted on patch set 1 V -1 03/09/21, 11:28 Completed build in 06m 56s on Tue, 9 Mar, 11:28 AM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9961
-
core-ci voted on patch set 1 V -1 03/09/21, 11:31 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1313
-
Oli Bartsch uploaded patch set 2 03/09/21, 11:37
-
TYPO3com voted on patch set 2 V +1 03/09/21, 11:43 Completed build in 06m 04s on Tue, 9 Mar, 11:43 AM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9962
-
core-ci voted on patch set 2 V +1 03/09/21, 11:49 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1314
-
Oliver Klee updated the commit message in patch set 3 03/09/21, 16:34
-
core-ci voted on patch set 3 V +1 03/09/21, 16:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1336
-
TYPO3com voted on patch set 3 V +1 03/09/21, 16:50 Completed build in 10m 08s on Tue, 9 Mar, 04:50 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9981
-
Oli Bartsch updated the commit message in patch set 4 03/09/21, 17:01
-
Oli Bartsch commented on patch set 4 03/09/21, 17:02
@Oliver Klee: The term "otpauth" was intended since it's the URI scheme for such URLs. -
TYPO3com voted on patch set 4 V +1 03/09/21, 17:09 Completed build in 08m 03s on Tue, 9 Mar, 05:09 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9984
-
core-ci voted on patch set 4 V +1 03/09/21, 17:12 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1339
-
Oliver Klee commented on patch set 4 03/10/21, 14:19
Reply
Is "otpauth" (all lowercase, no space) really the official term? Do you have a reference for this? (I could not find anything for this, only "otpauth" as library/packages names.) -
Oli Bartsch commented on patch set 4 03/10/21, 16:22
Reply
With "otpauth" I refer to the scheme otpauth://. See: https://github.com/google/google-authenticator/wiki/Key-Uri-Format -
Benjamin Franzke commented on patch set 4 CR -1 03/10/21, 19:45
Setup.html:38Let's use a custom element instead (for new code like this). Will provide. -
Benjamin Franzke uploaded patch set 5 03/10/21, 20:26
-
Benjamin Franzke commented on patch set 5 03/10/21, 20:26
Setup.html:38ReplyDone -
TYPO3com voted on patch set 5 V +1 03/10/21, 20:35 Completed build in 08m 42s on Wed, 10 Mar, 08:35 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10024
-
core-ci voted on patch set 5 V +1 03/10/21, 20:37 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1384
-
Benjamin Franzke uploaded patch set 6 03/10/21, 20:46
-
TYPO3com voted on patch set 6 V +1 03/10/21, 20:53 Completed build in 07m 08s on Wed, 10 Mar, 08:53 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10026
-
Benjamin Franzke voted on patch set 6 V +1 CR +1 03/10/21, 20:56
-
core-ci voted on patch set 6 V +1 03/10/21, 21:00 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1386
-
Benjamin Franzke commented on patch set 6 03/10/21, 21:17
Reply
Ack -
Oliver Klee wrote 03/10/21, 22:42
Removed reviewer Oliver Klee. -
Benjamin Franzke uploaded patch set 7 03/11/21, 08:18
-
TYPO3com voted on patch set 7 V +1 03/11/21, 08:25 Completed build in 07m 23s on Thu, 11 Mar, 08:25 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10042
-
core-ci voted on patch set 7 V +1 03/11/21, 08:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1406
-
Georg Ringer voted on patch set 7 V +2 CR +2 03/11/21, 09:20
-
Georg Ringer merged patch set 8 03/11/21, 09:20