Review main Merged

68293[TASK] Show otpauth URL next to shared secret

Oli Bartsch CR +2 V +2 Normal +132 −10 updated 03/11/21, 09:20

Commit message

The MFA TOTP provider is based on a shared secret. Therefore,
to set this provider up, the secret has to be exchanged between
TYPO3 and the corresponding OTP application or device.

This can either be done by:

* Scanning the QR code
* Entering the shared secret directly

While the shared secret does not contain any additional data,
the QR code contains the so-called otpauth URL, a common URI
scheme, accepted by most OTP applications. This URL features
additional information like the issuer and the related account.

To improve the usability, the user is now able to also access
this URL directly through a new modal with further explanation.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 5

Review log 1731

Show 26 earlier messages
  1. Oli Bartsch uploaded patch set 1 03/09/21, 11:21

  2. TYPO3com voted on patch set 1 V -1 03/09/21, 11:28 Completed build in 06m 56s on Tue, 9 Mar, 11:28 AM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9961

  3. core-ci voted on patch set 1 V -1 03/09/21, 11:31 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1313

  4. Oli Bartsch uploaded patch set 2 03/09/21, 11:37

  5. TYPO3com voted on patch set 2 V +1 03/09/21, 11:43 Completed build in 06m 04s on Tue, 9 Mar, 11:43 AM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9962

  6. core-ci voted on patch set 2 V +1 03/09/21, 11:49 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1314

  1. Oliver Klee updated the commit message in patch set 3 03/09/21, 16:34

  2. core-ci voted on patch set 3 V +1 03/09/21, 16:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1336

  3. TYPO3com voted on patch set 3 V +1 03/09/21, 16:50 Completed build in 10m 08s on Tue, 9 Mar, 04:50 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9981

  4. Oli Bartsch updated the commit message in patch set 4 03/09/21, 17:01

  5. Oli Bartsch commented on patch set 4 03/09/21, 17:02

    @Oliver Klee: The term "otpauth" was intended since it's the URI scheme for such URLs.
  6. TYPO3com voted on patch set 4 V +1 03/09/21, 17:09 Completed build in 08m 03s on Tue, 9 Mar, 05:09 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9984

  7. core-ci voted on patch set 4 V +1 03/09/21, 17:12 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1339

  8. Oliver Klee commented on patch set 4 03/10/21, 14:19

    Reply

    Is "otpauth" (all lowercase, no space) really the official term? Do you have a reference for this? (I could not find anything for this, only "otpauth" as library/packages names.)
  9. Oli Bartsch commented on patch set 4 03/10/21, 16:22

    Reply

    With "otpauth" I refer to the scheme otpauth://. See: https://github.com/google/google-authenticator/wiki/Key-Uri-Format
  10. Benjamin Franzke commented on patch set 4 CR -1 03/10/21, 19:45

    Setup.html:38

    Let's use a custom element instead (for new code like this). Will provide.
  11. Benjamin Franzke uploaded patch set 5 03/10/21, 20:26

  12. Benjamin Franzke commented on patch set 5 03/10/21, 20:26

    Setup.html:38 Reply

    Done
  13. TYPO3com voted on patch set 5 V +1 03/10/21, 20:35 Completed build in 08m 42s on Wed, 10 Mar, 08:35 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10024

  14. core-ci voted on patch set 5 V +1 03/10/21, 20:37 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1384

  15. Benjamin Franzke uploaded patch set 6 03/10/21, 20:46

  16. TYPO3com voted on patch set 6 V +1 03/10/21, 20:53 Completed build in 07m 08s on Wed, 10 Mar, 08:53 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10026

  17. Benjamin Franzke voted on patch set 6 V +1 CR +1 03/10/21, 20:56

  18. core-ci voted on patch set 6 V +1 03/10/21, 21:00 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1386

  19. Benjamin Franzke commented on patch set 6 03/10/21, 21:17

    Reply

    Ack
  20. Oliver Klee wrote 03/10/21, 22:42

    Removed reviewer Oliver Klee.
  21. Benjamin Franzke uploaded patch set 7 03/11/21, 08:18

  22. TYPO3com voted on patch set 7 V +1 03/11/21, 08:25 Completed build in 07m 23s on Thu, 11 Mar, 08:25 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10042

  23. core-ci voted on patch set 7 V +1 03/11/21, 08:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1406

  24. Georg Ringer voted on patch set 7 V +2 CR +2 03/11/21, 09:20

  25. Georg Ringer merged patch set 8 03/11/21, 09:20