Review main Merged

68294[TASK] Fix PHP 8 compatibility issues part 4/x

Christian Kuhn CR +2 V +2 Normal +73 −70 updated 03/09/21, 15:58

Commit message

Milestone: With a last series of type handling and
array access fixes throughout core and in
typo3/testing-framework, a first set of functional
pre-merge tests can be enabled with PHP 8.0.

composer req --dev typo3/testing-framework:^6.7.2

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 19

Review log 818

  1. Christian Kuhn uploaded patch set 1 03/09/21, 11:53

  2. TYPO3com voted on patch set 1 V -1 03/09/21, 11:53 Completed build in 16s on Tue, 9 Mar, 11:53 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9963

  3. Christian Kuhn uploaded patch set 2 03/09/21, 11:55

  4. TYPO3com voted on patch set 2 V -1 03/09/21, 12:02 Completed build in 07m 17s on Tue, 9 Mar, 12:02 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9964

  5. core-ci voted on patch set 1 V -1 03/09/21, 13:54 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1315

  6. core-ci voted on patch set 2 V -1 03/09/21, 13:58 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1316

  7. Christian Kuhn uploaded patch set 3 03/09/21, 13:59

  8. TYPO3com voted on patch set 3 V -1 03/09/21, 14:05 Completed build in 05m 27s on Tue, 9 Mar, 02:05 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9967

  9. core-ci voted on patch set 3 V -1 03/09/21, 14:17 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1321

  10. Christian Kuhn uploaded patch set 4 03/09/21, 14:55

  11. TYPO3com voted on patch set 4 V -1 03/09/21, 15:01 Completed build in 05m 37s on Tue, 9 Mar, 03:01 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9973

  12. core-ci voted on patch set 4 V -1 03/09/21, 15:05 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1327

  13. Christian Kuhn uploaded patch set 5 03/09/21, 15:07

  14. TYPO3com voted on patch set 5 V +1 03/09/21, 15:17 Completed build in 09m 13s on Tue, 9 Mar, 03:17 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9974

  15. core-ci voted on patch set 5 V +1 03/09/21, 15:21 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1329

  16. Richard Haeser voted on patch set 5 V +1 CR +1 03/09/21, 15:32

  17. Benni Mack voted on patch set 5 V +2 CR +2 03/09/21, 15:58

  18. Benni Mack merged patch set 6 03/09/21, 15:58