Review main Merged

68301[BUGFIX] Fix TypeError in InlineControlContainer

Oli Bartsch CR +2 V +2 Easy +4 −1 updated 03/11/21, 16:22

Commit message

In case a TCA column with type=inline does not
contain "container controls", e.g. the `languages`
column in a site configuration, a TypeError was
triggered by the toggleContainerControls() method.

This is fixed by proper type checking.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Oli Bartsch uploaded patch set 1 03/09/21, 23:21

  2. TYPO3com voted on patch set 1 V +1 03/09/21, 23:28 Completed build in 07m 15s on Tue, 9 Mar, 11:28 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9994

  3. core-ci voted on patch set 1 V +1 03/09/21, 23:37 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1349

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 03/11/21, 16:21

  5. Benni Mack voted on patch set 1 V +2 CR +2 03/11/21, 16:22

  6. Benni Mack merged patch set 2 03/11/21, 16:22