Review main Merged

68302[BUGFIX] Adjust tab menu styling

Oli Bartsch CR +2 V +2 Easy +19 −22 updated 03/11/21, 16:25

Commit message

Because bootstrap 5 requires the `.nav-link` class for styling
of nav tab links, our custom SCSS now uses the class selector
together with the type selector. Otherwise it will be overruled
by the default bootstrap styles because of their specificity.

See: https://getbootstrap.com/docs/5.0/components/navs-tabs/#fill-and-justify

Furthermore is the `.active` class, indicating the active tab,
not longer set on the `.nav-item` element, but on the `.nav-link`
element. The custom SCSS is therefore adjusted to respect this
changed behaviour.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 610

  1. Oli Bartsch uploaded patch set 1 03/10/21, 00:13

  2. Oli Bartsch wrote 03/10/21, 00:14

    Topic set to bootstrap5
  3. TYPO3com voted on patch set 1 V +1 03/10/21, 00:20 Completed build in 06m 42s on Wed, 10 Mar, 12:20 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9995

  4. core-ci voted on patch set 1 V +1 03/10/21, 00:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1350

  5. Oli Bartsch uploaded patch set 2 03/10/21, 17:33

  6. TYPO3com voted on patch set 2 V +1 03/10/21, 17:40 Completed build in 07m 31s on Wed, 10 Mar, 05:40 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10022

  7. core-ci voted on patch set 2 V +1 03/10/21, 17:52 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1381

  8. Benni Mack voted on patch set 2 V +1 CR +1 03/11/21, 14:22

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 03/11/21, 16:25

  10. Christian Kuhn merged patch set 3 03/11/21, 16:25