68303[TASK] Separate concerns in SVGTree implementations
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Richard Haeser +1
-
Verified V +2 Done
- Georg Ringer +2
- Richard Haeser +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 16
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectTree.ts+127 −45
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectTreeElement.ts+140 −7
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/TreeToolbar.tsdeleted+0 −171
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTree.ts+135 −143
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTreeDragDrop.ts+2 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTreeElement.ts+1 −2
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/FileStorageTree.ts+0 −4
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/TreeNode.ts+0 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/SvgTree.ts+18 −81
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTreeElement.js+21 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/TreeToolbar.jsdeleted+0 −33
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageTree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js+1 −1
Review log 818
-
Benni Mack uploaded patch set 1 03/10/21, 07:23
-
TYPO3com voted on patch set 1 V +1 03/10/21, 07:31 Completed build in 08m 28s on Wed, 10 Mar, 07:31 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9996
-
core-ci voted on patch set 1 V +1 03/10/21, 07:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1354
-
Benni Mack uploaded patch set 2 03/10/21, 08:04
-
TYPO3com voted on patch set 2 V -1 03/10/21, 08:12 Completed build in 07m 48s on Wed, 10 Mar, 08:12 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9997
-
core-ci voted on patch set 2 V -1 03/10/21, 08:14 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1355
-
Benni Mack uploaded patch set 3 03/10/21, 08:23
-
TYPO3com voted on patch set 3 V +1 03/10/21, 08:33 Completed build in 09m 29s on Wed, 10 Mar, 08:33 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9998
-
core-ci voted on patch set 3 V -1 03/10/21, 08:36 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1356
-
Benni Mack uploaded patch set 4 03/10/21, 08:55
-
TYPO3com voted on patch set 4 V +1 03/10/21, 09:03 Completed build in 07m 44s on Wed, 10 Mar, 09:03 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9999
-
core-ci voted on patch set 4 V -1 03/10/21, 09:06 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1357
-
Benni Mack uploaded patch set 5 03/10/21, 09:31
-
TYPO3com voted on patch set 5 V +1 03/10/21, 09:41 Completed build in 09m 25s on Wed, 10 Mar, 09:41 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10000
-
core-ci voted on patch set 5 V +1 03/10/21, 09:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1358
-
Richard Haeser voted on patch set 5 V +1 CR +1 03/10/21, 10:59
-
Georg Ringer voted on patch set 5 V +2 CR +2 03/10/21, 11:05
-
Georg Ringer merged patch set 6 03/10/21, 11:05