Review main Merged

68303[TASK] Separate concerns in SVGTree implementations

Benni Mack CR +2 V +2 Hard +449 −494 updated 03/10/21, 11:05

Commit message

This patch provides the following changes in order to
have better abstractions and encapsulate the dependencies
of each implementation.

1. SelectTree (Category Tree)

The TreeToolbar is now clearly coupled into the SelectTree
and built as LitElement inside the SelectTreeElement.

SelectTree now contains all relevant functionality
regarding selecting multiple items, and shows settings
(SelectTreeSettings) which were only used in SelectTree.

This is especially relevant for the multiple item selection,
and the exclusiveKey handling.

2. PageTree + FileStorageTree
Obsolete public methods are removed, and visibility is changed.
Filtering is now separated in favor of a non-public property.
By using Types (in e.g. PageTreeDragDrop) the visibility is also adapted
Obsolete wrapper methods are removed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 16

Review log 818

  1. Benni Mack uploaded patch set 1 03/10/21, 07:23

  2. TYPO3com voted on patch set 1 V +1 03/10/21, 07:31 Completed build in 08m 28s on Wed, 10 Mar, 07:31 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9996

  3. core-ci voted on patch set 1 V +1 03/10/21, 07:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1354

  4. Benni Mack uploaded patch set 2 03/10/21, 08:04

  5. TYPO3com voted on patch set 2 V -1 03/10/21, 08:12 Completed build in 07m 48s on Wed, 10 Mar, 08:12 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9997

  6. core-ci voted on patch set 2 V -1 03/10/21, 08:14 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1355

  7. Benni Mack uploaded patch set 3 03/10/21, 08:23

  8. TYPO3com voted on patch set 3 V +1 03/10/21, 08:33 Completed build in 09m 29s on Wed, 10 Mar, 08:33 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9998

  9. core-ci voted on patch set 3 V -1 03/10/21, 08:36 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1356

  10. Benni Mack uploaded patch set 4 03/10/21, 08:55

  11. TYPO3com voted on patch set 4 V +1 03/10/21, 09:03 Completed build in 07m 44s on Wed, 10 Mar, 09:03 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9999

  12. core-ci voted on patch set 4 V -1 03/10/21, 09:06 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1357

  13. Benni Mack uploaded patch set 5 03/10/21, 09:31

  14. TYPO3com voted on patch set 5 V +1 03/10/21, 09:41 Completed build in 09m 25s on Wed, 10 Mar, 09:41 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10000

  15. core-ci voted on patch set 5 V +1 03/10/21, 09:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1358

  16. Richard Haeser voted on patch set 5 V +1 CR +1 03/10/21, 10:59

  17. Georg Ringer voted on patch set 5 V +2 CR +2 03/10/21, 11:05

  18. Georg Ringer merged patch set 6 03/10/21, 11:05