Review main Merged

68304[BUGFIX] Include IP in authentication logs

Markus Klein CR +2 V +2 Easy +3 −3 updated 03/11/21, 13:03

Commit message

Logs written via the logging API now include the correct
remote address instead of the marker ###IP###.

Additionally, some actions were logged twice, this is
streamlined.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Josef Glatz +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Josef Glatz +1
    • Torben Hansen +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Markus Klein uploaded patch set 1 03/10/21, 10:23

  2. TYPO3com voted on patch set 1 V +1 03/10/21, 10:32 Completed build in 08m 16s on Wed, 10 Mar, 10:32 AM Test Summary: 32679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10002

  3. core-ci voted on patch set 1 V +1 03/10/21, 10:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1360

  4. Torben Hansen commented on patch set 1 V +1 CR +1 03/10/21, 18:44

    I think it is ok that we switch from "info" to "notice" for the invalid password logging.
  5. Markus Klein commented on patch set 1 03/10/21, 19:24

    Reply

    We do not actually "switch". We simply leave the "info" out, the "notice" has always been there
  6. Josef Glatz voted on patch set 1 V +1 CR +1 03/11/21, 10:25

  7. Richard Haeser voted on patch set 1 V +2 CR +2 03/11/21, 13:03

  8. Richard Haeser merged patch set 2 03/11/21, 13:03