Review main Merged

68307[TASK] Move temporary mount point handling into PageTreeElement

Benni Mack CR +2 V +2 Normal +79 −99 updated 03/10/21, 16:43

Commit message

As the temporary mount point functionality is not bound to
the actual PageTree, but the navigation component, this
code is now moved outside of the PageTree, and using
lit-based rendering and proper event handling.

The advantages of this change are that the SVG
Tree / PageTree component
- does not access HTML outside its own wrapper (parentNode)
- the mount point information is now rendered via LIT (= automatically updated)
- additional setting "temporaryMountPointPath" is not needed inside the PageTree anymore
- We also now use <typo3-backend-icon> and the $lll lit helper

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Daniel Sattler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Daniel Sattler +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 6

Review log 1329

Show 24 earlier messages
  1. Benni Mack uploaded patch set 1 03/10/21, 12:20

  2. TYPO3com voted on patch set 1 V +1 03/10/21, 12:28 Completed build in 07m 16s on Wed, 10 Mar, 12:28 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10006

  3. Benni Mack uploaded patch set 2 03/10/21, 12:28

  4. core-ci voted on patch set 1 V +1 03/10/21, 12:31 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1364

  1. TYPO3com voted on patch set 2 V +1 03/10/21, 12:36 Completed build in 07m 47s on Wed, 10 Mar, 12:36 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10007

  2. core-ci voted on patch set 2 V +1 03/10/21, 12:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1365

  3. Benjamin Franzke uploaded patch set 3 03/10/21, 12:49

  4. TYPO3com voted on patch set 3 V +1 03/10/21, 12:59 Completed build in 10m 10s on Wed, 10 Mar, 12:59 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10009

  5. core-ci voted on patch set 3 V +1 03/10/21, 12:59 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1367

  6. Benni Mack uploaded patch set 4 03/10/21, 13:18

  7. Benni Mack updated the commit message in patch set 5 03/10/21, 13:19

  8. core-ci voted on patch set 4 V +1 03/10/21, 13:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1368

  9. Benjamin Franzke commented on patch set 5 CR -1 03/10/21, 13:30

    _svgtree.scss:338

    0 0 1 is not a valid flex value. Will fix (you wanted 0 0 auto, or simply 0).
  10. TYPO3com voted on patch set 4 V +1 03/10/21, 13:31 Completed build in 13m 08s on Wed, 10 Mar, 01:31 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10010

  11. TYPO3com voted on patch set 5 V +1 03/10/21, 13:32 Completed build in 12m 46s on Wed, 10 Mar, 01:32 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10011

  12. core-ci voted on patch set 5 V +1 03/10/21, 13:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1369

  13. Benjamin Franzke uploaded patch set 6 03/10/21, 13:36

  14. Benjamin Franzke commented on patch set 6 03/10/21, 13:36

    _svgtree.scss:338 Reply

    Done
  15. TYPO3com voted on patch set 6 V +1 03/10/21, 13:44 Completed build in 08m 36s on Wed, 10 Mar, 01:44 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10014

  16. core-ci voted on patch set 6 V +1 03/10/21, 13:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1372

  17. Benni Mack uploaded patch set 7 03/10/21, 14:22

  18. core-ci commented on patch set 7 03/10/21, 14:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1373

  19. TYPO3com commented on patch set 7 03/10/21, 14:32 Completed build in 10m 20s on Wed, 10 Mar, 02:32 PM Test Summary: 32678 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10015

  20. Benni Mack uploaded patch set 8 03/10/21, 15:22

  21. TYPO3com commented on patch set 8 03/10/21, 15:31 Completed build in 08m 59s on Wed, 10 Mar, 03:31 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10018

  22. core-ci commented on patch set 8 03/10/21, 15:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1376

  23. Daniel Sattler voted on patch set 8 V +1 CR +1 03/10/21, 16:42

  24. Benni Mack voted on patch set 8 V +2 CR +2 03/10/21, 16:43

  25. Benni Mack merged patch set 9 03/10/21, 16:43