Review main Merged

68310[BUGFIX] Use correct data for cObj in ClickEnlargeViewHelper

Markus Klein CR +2 V +2 Easy +11 −1 updated 03/17/21, 07:41

Commit message

Set the current content element record as data for the cObj
used to generate the click-enlarge code for images.

This ensures that the default dataWrap used in TypoScript
actually gets the uid of the content element and not the
current page.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Markus Klein uploaded patch set 1 03/10/21, 17:32

  2. TYPO3com voted on patch set 1 V +1 03/10/21, 17:40 Completed build in 07m 48s on Wed, 10 Mar, 05:40 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10021

  3. core-ci voted on patch set 1 V +1 03/10/21, 17:43 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1380

  4. Benjamin Franzke voted on patch set 1 CR +1 03/10/21, 21:51

  5. Georg Ringer voted on patch set 1 V +1 CR +1 03/16/21, 20:00

  6. Benni Mack voted on patch set 1 V +2 CR +2 03/17/21, 07:41

  7. Benni Mack merged patch set 2 03/17/21, 07:41