Review main Merged

68311[BUGFIX] FormEngine: Consider checkboxes representing a value only in selectCheckBox

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 03/10/21, 21:05

Commit message

The introduced validation of checkboxes in `selectCheckBox` took the
"Toggle all" checkbox into account as well which broke in combination
with a `maxitems` constraint.

This patch now takes only checkboxes with a `value` attribute into
consideration.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 1

Review log 46

  1. Andreas Kienast uploaded patch set 1 03/10/21, 20:45

  2. TYPO3com voted on patch set 1 V +1 03/10/21, 20:55 Completed build in 09m 55s on Wed, 10 Mar, 08:55 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10025

  3. Markus Klein voted on patch set 1 V +1 CR +1 03/10/21, 20:57

  4. core-ci voted on patch set 1 V +1 03/10/21, 20:57 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1385

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 03/10/21, 21:04

  6. Benjamin Franzke merged patch set 2 03/10/21, 21:05