Review 10.4 Merged

68330[BUGFIX] Revert "Make ClassSchema PHP 8 compatible"

Benni Mack CR +2 V +2 Easy +8 −35 updated 03/15/21, 22:02

Commit message

The change makes "e712dc9e531b0f23c2ca7459337ab56739262465"
existing Extbase installations broken, so this is reverted.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 4

Review log 47

  1. Benni Mack commented on patch set 1 03/15/21, 16:15

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 03/15/21, 16:25 Completed build in 10m 16s on Mon, 15 Mar, 04:25 PM Test Summary: 1 of 75962 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1221

  3. TYPO3com voted on patch set 1 V +1 03/15/21, 16:29 Completed build in 24m 14s on Mon, 15 Mar, 04:29 PM Test Summary: 75477 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1221

  4. core-ci voted on patch set 1 V +1 03/15/21, 16:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1557

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 03/15/21, 16:36

  6. Oliver Hader voted on patch set 1 V +2 CR +2 03/15/21, 22:02

  7. Oliver Hader merged patch set 2 03/15/21, 22:02