Review main Merged

68332[TASK] De-duplicate Tree code for filtering

Benni Mack CR +2 V +2 Hard +170 −261 updated 03/11/21, 09:48

Commit message

This change optimizes the SVG Tree implementations (again),
this time focussing on using proper constructors for SVG
tree and its derivatives (SelectTree, PageTree, FileStorageTree).

In addition, the search + filter logic is now moved
into the base class, in order to reduce duplicate code,
and to re-add features (next steps) that were not
implemented in TYPO3 v9 when re-writing the page tree,
such as highlighting filtered results.

In addition, unused properties and settings are
removed.

This change marks one of the final changes for
reworking the SVG Tree implementation, afterwards
allowing us to move towards:
* native DOM events in favor of d3-dispatch
* custom elements instead of wrapper methods
* decouple "top." and "document." based settings into the Container classes

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Georg Ringer +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 14

Review log 612

  1. Benni Mack uploaded patch set 1 03/10/21, 21:12

  2. core-ci voted on patch set 1 V -1 03/10/21, 21:24 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1390

  3. TYPO3com voted on patch set 1 V +1 03/10/21, 21:27 Completed build in 13m 44s on Wed, 10 Mar, 09:26 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10029

  4. Benni Mack uploaded patch set 2 03/11/21, 00:15

  5. TYPO3com voted on patch set 2 V +1 03/11/21, 00:23 Completed build in 07m 21s on Thu, 11 Mar, 12:23 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10039

  6. core-ci voted on patch set 2 V +1 03/11/21, 00:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1400

  7. Benni Mack updated the commit message in patch set 3 03/11/21, 00:26

  8. TYPO3com voted on patch set 3 V +1 03/11/21, 00:33 Completed build in 06m 27s on Thu, 11 Mar, 12:33 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10040

  9. core-ci voted on patch set 3 V +1 03/11/21, 00:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1401

  10. Georg Ringer voted on patch set 3 V +1 CR +1 03/11/21, 07:27

  11. Richard Haeser voted on patch set 3 V +2 CR +2 03/11/21, 09:48

  12. Richard Haeser merged patch set 4 03/11/21, 09:48