Review main Merged

68334[BUGFIX] Show cookie warning only for successful authentication

Markus Klein CR +2 V +2 Easy +1 −1 updated 03/15/21, 18:29

Commit message

The login dialog may show a cookie warning.
This has only to be shown if the authentication was successful, but the
cookie has not been accepted by the browser.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Markus Klein uploaded patch set 1 03/10/21, 21:52

  2. TYPO3com voted on patch set 1 V +1 03/10/21, 22:03 Completed build in 10m 37s on Wed, 10 Mar, 10:03 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10035

  3. core-ci voted on patch set 1 V +1 03/10/21, 22:03 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1396

  4. Benni Mack voted on patch set 1 V +1 CR +1 03/11/21, 19:51

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 03/11/21, 21:35

  6. Richard Haeser voted on patch set 1 V +2 CR +2 03/15/21, 18:29

  7. Richard Haeser merged patch set 2 03/15/21, 18:29