Review main Abandoned

68335[WIP][TASK] Reduce fieldChangeFunc definitions

Andreas Kienast CR 0 V 0 Normal +103 −70 updated 04/11/21, 15:28

Commit message

To reduce the amount of inline JavaScript in DOM and to allow improved
handling, the fieldChangeFunc definitions in FormEngine are reduced and
are subject to get removed later on, but are kept for compatibility
reasons for now.

In a follow-up patch, the function TBE_EDITOR.fieldChanged() can finally
become deprecated.

Review

  • Code review CR 0
  • Verified V 0

Files 16

Review log 820

  1. Andreas Kienast uploaded patch set 1 03/10/21, 23:32

  2. TYPO3com voted on patch set 1 V -1 03/10/21, 23:42 Completed build in 09m 43s on Wed, 10 Mar, 11:42 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10038

  3. core-ci voted on patch set 1 V -1 03/10/21, 23:43 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1399

  4. Andreas Kienast uploaded patch set 2 04/02/21, 12:38

  5. TYPO3com voted on patch set 2 V -1 04/02/21, 12:45 Completed build in 06m 36s on Fri, 2 Apr, 12:45 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10464

  6. core-ci voted on patch set 2 V -1 04/02/21, 12:51 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1998

  7. Andreas Kienast uploaded patch set 3 04/02/21, 14:36

  8. TYPO3com voted on patch set 3 V +1 04/02/21, 14:44 Completed build in 07m 50s on Fri, 2 Apr, 02:44 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10465

  9. core-ci voted on patch set 3 V -1 04/02/21, 14:47 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1999

  10. Andreas Kienast uploaded patch set 4 04/02/21, 14:54

  11. TYPO3com voted on patch set 4 V +1 04/02/21, 15:01 Completed build in 06m 30s on Fri, 2 Apr, 03:01 PM Test Summary: 33266 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10466

  12. core-ci voted on patch set 4 V +1 04/02/21, 15:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2000

  13. Andreas Kienast commented on patch set 4 CR -2 04/02/21, 15:13

    https://review.typo3.org/c/Packages/TYPO3.CMS/+/68671 should go in first as it's for 10.4 as well.
  14. Andreas Kienast uploaded patch set 5 04/11/21, 14:02

  15. Andreas Kienast uploaded patch set 6 04/11/21, 14:04

  16. TYPO3com voted on patch set 5 V +1 04/11/21, 14:08 Completed build in 06m 38s on Sun, 11 Apr, 02:08 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10600

  17. TYPO3com voted on patch set 6 V +1 04/11/21, 14:10 Completed build in 05m 58s on Sun, 11 Apr, 02:10 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10601

  18. core-ci voted on patch set 5 V +1 04/11/21, 14:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2173

  19. core-ci voted on patch set 6 V +1 04/11/21, 14:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2174

  20. Andreas Kienast abandoned the change 04/11/21, 15:28