Review main Merged

68336[TASK] Update CKEditor to 4.16.0

Georg Ringer CR +2 V +2 Nightmare +2332 −2172 updated 03/12/21, 08:37

Commit message

Update from 4.15.0 to 4.16.0 to use the latest bugfix release
which also includes security related fixes of 4.15.1 in plugins which
are not used by TYPO3.

Changelog: https://github.com/ckeditor/ckeditor4/blob/major/CHANGES.md

Executed commands:

cd Build
yarn add ckeditor4@^4.16.0
yarn build

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Josef Glatz +1
    • Markus Klein +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Josef Glatz +1
    • Marco Bresch +1
    • Markus Klein +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 1

Files 843

Show 823 more files

Review log 1419

  1. Georg Ringer uploaded patch set 1 03/11/21, 09:18

  2. Georg Ringer commented on patch set 1 03/11/21, 09:18

    This change is ready for review.
  3. Oliver Hader updated the commit message in patch set 2 03/11/21, 09:25

  4. TYPO3com voted on patch set 1 V +1 03/11/21, 09:26 Completed build in 07m 57s on Thu, 11 Mar, 09:26 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10043

  5. core-ci voted on patch set 1 V +1 03/11/21, 09:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1407

  6. TYPO3com voted on patch set 2 V +1 03/11/21, 09:32 Completed build in 07m 05s on Thu, 11 Mar, 09:32 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10044

  7. core-ci voted on patch set 2 V +1 03/11/21, 09:35 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1408

  8. Oli Bartsch updated the commit message in patch set 3 03/11/21, 09:37

  9. core-ci voted on patch set 3 V +1 03/11/21, 09:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1409

  10. Markus Klein voted on patch set 3 V +1 CR +1 03/11/21, 10:21

  11. Josef Glatz commented on patch set 3 V +1 CR +1 03/11/21, 14:17

    I can remember some customers from jLeiwand had some troubles with some regressions in CKE in former updates. I'm definitively for an upgrade also in 9.5. But what about adding an important rst for "older" branches and mention also the security part?
  12. Marco Bresch voted on patch set 3 V +1 03/11/21, 20:22

  13. Stefan Froemken commented on patch set 3 V +1 CR +1 03/11/21, 22:18

    Buttons/Features of TYPO3 CkEditor default configuration are working. IMO this update is more a must have because of security fixes: https://ckeditor.com/cke4/release/CKEditor-4.16.0
  14. Stefan Froemken commented on patch set 3 03/12/21, 07:43

    Nothing known to Wolfgang, Jochen and me.
  15. Oliver Hader voted on patch set 3 CR +1 03/12/21, 07:49

  16. Oliver Hader voted on patch set 3 V +1 03/12/21, 07:50

  17. Oliver Hader voted on patch set 3 V +2 CR +2 03/12/21, 07:50

  18. Oliver Hader merged patch set 4 03/12/21, 07:51

  19. Josef Glatz commented on patch set 4 03/12/21, 08:37

    for the reference: talked with Benni. we both thought that some customer(s) of Jochen had some bigger troubles after a cke update. But anyway! CKE updates need to be done. Cool that all of them were merged!