Review 9.5 Merged

68341[BUGFIX] Fix serialization of FileReference objects

Oliver Hader CR +2 V +2 Normal +36 −19 updated 03/11/21, 14:32

Commit message

FileReferences objects contain references to File
objects which itself contain service dependencies
(e.g. event dispatcher) which are not seralizable.

This leads to problems for instance when having
a multi-step form containing file uploads where
file reference objects are being serialized.

For TYPO3 v9.5 there is no direct exception, but serialized
data still contained lots of superfluous information. That's
why this change is back-ported to v9.5 as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Oliver Hader uploaded patch set 1 03/11/21, 10:44

  2. TYPO3com voted on patch set 1 V +1 03/11/21, 10:58 Completed build in 13m 06s on Thu, 11 Mar, 10:58 AM Test Summary: 75298 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1017

  3. core-ci voted on patch set 1 V +1 03/11/21, 11:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1414

  4. Benni Mack voted on patch set 1 V +2 CR +2 03/11/21, 14:32

  5. Benni Mack merged patch set 2 03/11/21, 14:32