Review 10.4 Merged

68347[BUGFIX] Fix TypeError in InlineControlContainer

Christian Kuhn CR +2 V +2 Easy +4 −1 updated 03/11/21, 19:41

Commit message

In case a TCA column with type=inline does not
contain "container controls", e.g. the `languages`
column in a site configuration, a TypeError was
triggered by the toggleContainerControls() method.

This is fixed by proper type checking.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Christian Kuhn uploaded patch set 1 03/11/21, 16:57

  2. TYPO3com voted on patch set 1 V +1 03/11/21, 17:07 Completed build in 09m 40s on Thu, 11 Mar, 05:07 PM Test Summary: 75471 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1187

  3. core-ci voted on patch set 1 V +1 03/11/21, 17:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1419

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 03/11/21, 19:40

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 03/11/21, 19:41

  6. Christian Kuhn merged patch set 2 03/11/21, 19:41