Review main Merged

68348[BUGFIX] Unknown column 't3ver_oid' in 'field list'

GAYA Manufacture digitale CR +2 V +2 Easy +4 −4 updated 03/12/21, 10:08

Commit message

EditDocumentController adds t3ver_oid field in SQL query for tables which don't use workspaces

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 715

  1. GAYA Manufacture digitale uploaded patch set 1 03/11/21, 16:59

  2. TYPO3com voted on patch set 1 V +1 03/11/21, 17:07 Completed build in 07m 57s on Thu, 11 Mar, 05:07 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10050

  3. core-ci voted on patch set 1 V -1 03/11/21, 17:13 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1420

  4. core-ci voted on patch set 1 V +1 03/11/21, 19:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1420

  5. Benni Mack commented on patch set 1 CR -1 03/11/21, 19:50

    great change, thanks for the fix.

    EditDocumentController.php:707 Unresolved

    this line also needs adaptions (strict typing)
  6. Benni Mack uploaded patch set 2 03/11/21, 20:59

  7. TYPO3com voted on patch set 2 V +1 03/11/21, 21:07 Completed build in 07m 29s on Thu, 11 Mar, 09:07 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10056

  8. core-ci voted on patch set 2 V -1 03/11/21, 21:13 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1428

  9. Christian Kuhn rebased onto patch set 3 03/11/21, 21:57

  10. TYPO3com voted on patch set 3 V +1 03/11/21, 22:05 Completed build in 07m 31s on Thu, 11 Mar, 10:05 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10065

  11. core-ci voted on patch set 3 V -1 03/11/21, 22:12 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1437

  12. core-ci voted on patch set 3 V +1 03/11/21, 22:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1437

  13. Benni Mack voted on patch set 3 V +1 CR +1 03/12/21, 08:00

  14. Georg Ringer voted on patch set 3 V +2 CR +2 03/12/21, 10:08

  15. Georg Ringer merged patch set 4 03/12/21, 10:08