Review main Merged

68356[BUGFIX] Prevent error in user settings when no language packs are installed

Richard Haeser CR +2 V +2 Easy +1 −1 updated 03/11/21, 20:53

Commit message

When no language packs are installed and
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['lang']['availableLanguages']
is not set, an empty array is now checked instead of throwing an error.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 712

  1. Richard Haeser uploaded patch set 1 03/11/21, 19:37

  2. TYPO3com voted on patch set 1 V +1 03/11/21, 19:44 Completed build in 07m 00s on Thu, 11 Mar, 07:44 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10051

  3. core-ci voted on patch set 1 V -1 03/11/21, 19:48 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1423

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 03/11/21, 19:48

  5. Christian Kuhn uploaded patch set 2 03/11/21, 20:26

  6. TYPO3com voted on patch set 2 V +1 03/11/21, 20:34 Completed build in 07m 28s on Thu, 11 Mar, 08:34 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10052

  7. core-ci voted on patch set 2 V +1 03/11/21, 20:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1424

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 03/11/21, 20:42

  9. Oli Bartsch voted on patch set 2 V +1 CR +1 03/11/21, 20:45

  10. Richard Haeser voted on patch set 2 V +2 CR +2 03/11/21, 20:46

  11. Richard Haeser merged patch set 3 03/11/21, 20:46

  12. core-ci voted on patch set 1 V +1 03/11/21, 20:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1423