Review main Merged

68358[TASK] Clean up ignored phpstan errors

Daniel Goerz CR +2 V +2 Normal +1 −151 updated 03/12/21, 14:22

Commit message

Remove entries from phpstan.neon for ignored errors
that have been fixed meanwhile. Parameter
reportUnmatchedIgnoredErrors finds those, but it is
false by default. We may drop that parameter with a
dedicated patch, but are currently not sure why it
is commented as 'needed for bamboo' at the moment.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 1222

  1. Daniel Goerz uploaded patch set 1 03/11/21, 20:50

  2. Daniel Goerz wrote 03/11/21, 20:54

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V +1 03/11/21, 20:57 Completed build in 07m 22s on Thu, 11 Mar, 08:57 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10054

  4. Daniel Goerz uploaded patch set 2 03/11/21, 21:04

  5. TYPO3com voted on patch set 2 V +1 03/11/21, 21:13 Completed build in 08m 08s on Thu, 11 Mar, 09:13 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10058

  6. Georg Ringer voted on patch set 2 V +1 CR +1 03/11/21, 21:20

  7. core-ci voted on patch set 2 V -1 03/11/21, 21:23 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1430

  8. Christian Kuhn rebased onto patch set 3 03/11/21, 21:53

  9. core-ci voted on patch set 1 V +1 03/11/21, 21:56 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1426

  10. TYPO3com voted on patch set 3 V +1 03/11/21, 22:01 Completed build in 08m 45s on Thu, 11 Mar, 10:01 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10064

  11. core-ci voted on patch set 3 V +1 03/11/21, 22:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1436

  12. Oliver Klee voted on patch set 3 CR +1 03/12/21, 10:43

  13. Christian Kuhn uploaded patch set 4 03/12/21, 11:15

  14. TYPO3com voted on patch set 4 V +1 03/12/21, 11:22 Completed build in 06m 59s on Fri, 12 Mar, 11:22 AM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10073

  15. core-ci voted on patch set 4 V -1 03/12/21, 11:28 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1451

  16. Christian Kuhn rebased onto patch set 5 03/12/21, 11:49

  17. TYPO3com voted on patch set 5 V +1 03/12/21, 11:57 Completed build in 08m 18s on Fri, 12 Mar, 11:57 AM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10075

  18. core-ci voted on patch set 5 V +1 03/12/21, 12:03 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1453

  19. Christian Kuhn voted on patch set 5 V +1 CR +1 03/12/21, 12:22

  20. Oliver Klee voted on patch set 5 CR +1 03/12/21, 12:34

  21. Richard Haeser voted on patch set 5 V +2 CR +2 03/12/21, 14:22

  22. Richard Haeser merged patch set 6 03/12/21, 14:22