Review main Merged

68359[TASK] Run phpstan with PHP 8 in nightly and premerge builds

Daniel Goerz CR +2 V +2 Hard +192 −103 updated 04/20/21, 17:44

Commit message

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 16

Review log 1224

  1. Daniel Goerz uploaded patch set 1 03/11/21, 21:00

  2. Daniel Goerz wrote 03/11/21, 21:01

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V +1 03/11/21, 21:08 Completed build in 07m 44s on Thu, 11 Mar, 09:08 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10057

  4. core-ci voted on patch set 1 V -1 03/11/21, 21:20 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1429

  5. Daniel Goerz rebased onto patch set 2 04/14/21, 14:20

  6. TYPO3com voted on patch set 2 V +1 04/14/21, 14:27 Completed build in 06m 30s on Wed, 14 Apr, 02:27 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10662

  7. core-ci voted on patch set 2 V -1 04/14/21, 14:31 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2247

  8. Daniel Goerz uploaded patch set 3 04/14/21, 18:49

  9. TYPO3com voted on patch set 3 V +1 04/14/21, 18:56 Completed build in 07m 20s on Wed, 14 Apr, 06:56 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10666

  10. core-ci voted on patch set 3 V -1 04/14/21, 18:59 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2251

  11. Daniel Goerz uploaded patch set 4 04/19/21, 15:52

  12. TYPO3com voted on patch set 4 V +1 04/19/21, 16:00 Completed build in 07m 02s on Mon, 19 Apr, 04:00 PM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10728

  13. core-ci voted on patch set 4 V -1 04/19/21, 16:03 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2336

  14. Daniel Goerz uploaded patch set 5 04/19/21, 16:30

  15. TYPO3com voted on patch set 5 V +1 04/19/21, 16:36 Completed build in 06m 20s on Mon, 19 Apr, 04:36 PM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10729

  16. core-ci voted on patch set 5 V +1 04/19/21, 16:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2337

  17. Daniel Goerz commented on patch set 5 04/19/21, 16:41

    This change is ready for review.
  18. Daniel Goerz updated the commit message in patch set 6 04/19/21, 16:42

  19. TYPO3com voted on patch set 6 V +1 04/19/21, 16:50 Completed build in 08m 20s on Mon, 19 Apr, 04:50 PM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10730

  20. core-ci voted on patch set 6 V +1 04/19/21, 16:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2338

  21. Benni Mack voted on patch set 6 V +1 CR +1 04/19/21, 18:03

  22. Jochen Roth voted on patch set 6 V +1 CR +1 04/20/21, 14:24

  23. Anja Leichsenring voted on patch set 6 V +2 CR +2 04/20/21, 17:44

  24. Anja Leichsenring merged patch set 7 04/20/21, 17:44