Review main Merged

68367[TASK] Use Lit-based template for SVG tree wrapper

Benni Mack CR +2 V +2 Hard +175 −192 updated 03/15/21, 09:22

Commit message

The SVG tree is now building the SVG elements
and needed containers ("<g>")  via lit-helper.

In addition, the update() method is renamed to
this.updateVisibleNodes() to easier integrate
this as Lit element, as update() is a reserved protected
method in lit.

The initialize() method is much cleaner, as the event listener
registration is now separated in a custom method.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • Daniel Gorges +1
  • Verified V +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • Daniel Gorges +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 20

Review log 1125

  1. Benni Mack uploaded patch set 1 03/12/21, 12:43

  2. TYPO3com voted on patch set 1 V +1 03/12/21, 12:48 Completed build in 04m 44s on Fri, 12 Mar, 12:48 PM Test Summary: 32692 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10078

  3. core-ci voted on patch set 1 V -1 03/12/21, 13:23 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1456

  4. Benni Mack uploaded patch set 2 03/12/21, 14:29

  5. Benni Mack uploaded patch set 3 03/12/21, 14:32

  6. TYPO3com voted on patch set 2 V +1 03/12/21, 14:38 Completed build in 08m 27s on Fri, 12 Mar, 02:38 PM Test Summary: 32701 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10082

  7. TYPO3com voted on patch set 3 V +1 03/12/21, 14:40 Completed build in 07m 37s on Fri, 12 Mar, 02:40 PM Test Summary: 32701 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10084

  8. Benni Mack uploaded patch set 4 03/12/21, 14:50

  9. TYPO3com voted on patch set 4 V +1 03/12/21, 14:58 Completed build in 08m 14s on Fri, 12 Mar, 02:58 PM Test Summary: 32701 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10087

  10. core-ci voted on patch set 4 V -1 03/12/21, 15:06 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1465

  11. core-ci voted on patch set 3 V -1 03/12/21, 15:25 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1462

  12. core-ci voted on patch set 2 V -1 03/12/21, 15:31 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1460

  13. Benni Mack uploaded patch set 5 03/12/21, 16:13

  14. TYPO3com voted on patch set 5 V +1 03/12/21, 16:20 Completed build in 07m 38s on Fri, 12 Mar, 04:20 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10090

  15. core-ci voted on patch set 5 V -1 03/12/21, 16:27 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1467

  16. Benni Mack uploaded patch set 6 03/12/21, 21:42

  17. TYPO3com voted on patch set 6 V +1 03/12/21, 21:50 Completed build in 07m 59s on Fri, 12 Mar, 09:50 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10099

  18. core-ci voted on patch set 6 V +1 03/12/21, 21:54 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1479

  19. Benni Mack rebased onto patch set 7 03/15/21, 08:58

  20. Richard Haeser voted on patch set 7 V +1 CR +1 03/15/21, 09:07

  21. TYPO3com voted on patch set 7 V +1 03/15/21, 09:08 Completed build in 09m 07s on Mon, 15 Mar, 09:08 AM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10133

  22. core-ci voted on patch set 7 V +1 03/15/21, 09:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1545

  23. Daniel Gorges voted on patch set 7 V +1 CR +1 03/15/21, 09:21

  24. Benni Mack voted on patch set 7 V +2 CR +2 03/15/21, 09:22

  25. Benni Mack merged patch set 8 03/15/21, 09:22