Review main Merged

68368[TASK] Speed up unit tests

Christian Kuhn CR +2 V +2 Easy +31 −16 updated 03/12/21, 14:51

Commit message

* Drop a TimeTracker test that does a sleep(1) to safe this
  second. The subject is pretty trivial anyways.
* The recently introduced MFA related unit tests receive
  some password hashing options to reduce calculation costs.
  This reduces suite execution time from ~60 seconds to ~40
  locally - totally worth it.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Richard Haeser +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 711

  1. Christian Kuhn uploaded patch set 1 03/12/21, 14:04

  2. TYPO3com voted on patch set 1 V +1 03/12/21, 14:12 Completed build in 08m 04s on Fri, 12 Mar, 02:12 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10081

  3. core-ci voted on patch set 1 V +1 03/12/21, 14:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1459

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 03/12/21, 14:20

  5. Christian Kuhn uploaded patch set 2 03/12/21, 14:30

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 03/12/21, 14:32

  7. TYPO3com voted on patch set 2 V +1 03/12/21, 14:38 Completed build in 07m 52s on Fri, 12 Mar, 02:38 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10083

  8. Richard Haeser voted on patch set 2 V +1 CR +1 03/12/21, 14:40

  9. core-ci voted on patch set 2 V +1 03/12/21, 14:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1461

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 03/12/21, 14:51

  11. Christian Kuhn merged patch set 3 03/12/21, 14:51