Review main Merged

68369[BUGFIX] Fixes search with search type "sentence"

Tina Westner CR +2 V +2 Easy +2 −1 updated 03/14/21, 18:41

Commit message

With this commit the method getSearchWords is called
after initializing $this->searchData, which is used there (only when
searchType is 20 - search for "sentence")

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 713

  1. Tina Westner uploaded patch set 1 03/12/21, 14:45

  2. TYPO3com voted on patch set 1 V +1 03/12/21, 14:53 Completed build in 07m 41s on Fri, 12 Mar, 02:53 PM Test Summary: 32701 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10085

  3. core-ci voted on patch set 1 V +1 03/12/21, 14:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1463

  4. Henrik Elsner commented on patch set 1 CR +1 03/13/21, 17:48

    I guess this could not only be merged for master
  5. Anja Leichsenring updated the commit message in patch set 2 03/14/21, 18:22

  6. Anja Leichsenring uploaded patch set 3 03/14/21, 18:25

  7. TYPO3com voted on patch set 2 V +1 03/14/21, 18:30 Completed build in 08m 05s on Sun, 14 Mar, 06:30 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10127

  8. core-ci voted on patch set 2 V +1 03/14/21, 18:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1530

  9. TYPO3com voted on patch set 3 V +1 03/14/21, 18:35 Completed build in 09m 39s on Sun, 14 Mar, 06:35 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10128

  10. core-ci voted on patch set 3 V +1 03/14/21, 18:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1531

  11. Anja Leichsenring voted on patch set 3 V +1 CR +1 03/14/21, 18:38

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 03/14/21, 18:40

  13. Christian Kuhn merged patch set 4 03/14/21, 18:41