68370[BUGFIX] Unify getSearchWords hook registration and call method
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1424
-
Tina Westner uploaded patch set 1 03/12/21, 14:45
-
TYPO3com voted on patch set 1 V +1 03/12/21, 14:54 Completed build in 08m 03s on Fri, 12 Mar, 02:54 PM Test Summary: 32701 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10086
-
core-ci voted on patch set 1 V +1 03/12/21, 15:01 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1464
-
Henrik Elsner updated the commit message in patch set 2 03/13/21, 17:52
-
Henrik Elsner updated the commit message in patch set 3 03/13/21, 17:56
-
Henrik Elsner commented on patch set 3 03/13/21, 17:59
I updated the commit message according to the guidelines. (at least i tried my best) The patch is pretty straight forward. The guidelines also mention the necessity of a rst file in case of breaking changes. -
TYPO3com voted on patch set 2 V +1 03/13/21, 17:59 Completed build in 07m 23s on Sat, 13 Mar, 05:59 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10105
-
TYPO3com voted on patch set 3 V +1 03/13/21, 18:01 Completed build in 05m 31s on Sat, 13 Mar, 06:01 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10106
-
core-ci voted on patch set 2 V +1 03/13/21, 18:03 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1488
-
core-ci voted on patch set 3 V +1 03/13/21, 18:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1489
-
Henrik Elsner voted on patch set 3 CR +1 03/13/21, 22:21
-
Christian Kuhn commented on patch set 3 CR -1 03/14/21, 18:48
Hey Tina, thanks for your patches. We just merged the other one :) Some details on this: * This patch should have an own issue on forge, not a re-use of #75845 that has been used for https://review.typo3.org/c/Packages/TYPO3.CMS/+/68369 already. Maybe just create a new issue and relate the two. * Please add an explanation in the commit message. I don't really understand whats going on. * What exactly is breaking? Could we somehow make this non-breaking? This would also allow a v10 backport. -
Tina Westner updated the commit message in patch set 4 03/15/21, 07:41
-
Henrik Elsner commented on patch set 4 03/15/21, 07:43
Reply
I removed the explanation of the commit as i thought this is pretty forward. The method that is needed to register the hook and the actual method that is called are different. If i understand that correctly this requires both methods instead of one for the usage of the hook. It is breaking as we change the way the hook is registered as we rename the method. -
TYPO3com voted on patch set 4 V +1 03/15/21, 07:49 Completed build in 07m 41s on Mon, 15 Mar, 07:49 AM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10132
-
core-ci voted on patch set 4 V +1 03/15/21, 07:52 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1544
-
Benni Mack updated the commit message in patch set 5 03/17/21, 07:43
-
Benni Mack commented on patch set 5 CR +1 03/17/21, 07:45
This isn't breaking, but actually a bugfix, so fine by me. -
TYPO3com voted on patch set 5 V +1 03/17/21, 07:52 Completed build in 08m 28s on Wed, 17 Mar, 07:52 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10178
-
core-ci voted on patch set 5 V +1 03/17/21, 08:00 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1622
-
Guido Schmechel commented on patch set 5 03/20/21, 10:08
If this is not Breaking, can we use it for the v10? I cannot read from the comments that this would be a problem. But I would rather ask :-) -
Daniel Goerz commented on patch set 5 CR -1 03/21/21, 19:24
This is a breaking change as hooks will no longer be executed unless they are registered differently. It needs a breaking RST explaining the new behaviour and how to migrate. TBH I dont know if this is even worth a breaking change. -
Christian Kuhn commented on patch set 5 11/04/21, 11:41
Hey. To take a decision here: This bug exists for a long time already - i followed it back to v7, but it's in there for a longer time already. The change as such *is* breaking since the registristration in $globals has to be changed from getSearchWords to getSearchWords_splitSWords - and I don't see non-ugly way to make this non-breaking. I'd say: Keep that annoying detail bug for now - Instead, we should strive for moving to psr-14 event-dispatcher (in v12?!) anyway ... having a breaking patch now for the hook usage is imho just not worth it. I'll go ahead and will abandon the patch for now, but would love to see changing the indexed_search hooks towards psr-14 event dispatching instead. -
Christian Kuhn abandoned the change 11/04/21, 11:41