Review main Merged

68371[TASK] Drop TsTemplate 'breakpoint' handling

Christian Kuhn CR +2 V +2 Normal +69 −64 updated 03/14/21, 15:45

Commit message

The backend template analyzer module has a 'breakpoint'
handling that works as follows: When a template is shown and
line numbers are enabled and one line number is clicked, a
link parameter jumps to the template object browser and
instructs it to parse TypoScript only up to this line to show
the state of constants or setup array up until this parsed point.

This hidden and not documented feature has been around since
'ever', with only a few persons knowing, understanding or even
actively using it. Last patch in this area was for TYPO3 4.4.

The implementation is quite messy and goes through various
classes, a bunch of properties and some inline javascript.

The patch drops the feature: It is not well known and of
limited use - the frontend does not reflect it and TypoScript
in general tends to become less complex nowadays.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 4

Files 8

Review log 917

  1. Christian Kuhn uploaded patch set 1 03/12/21, 20:24

  2. TYPO3com voted on patch set 1 V -1 03/12/21, 20:25 Completed build in 17s on Fri, 12 Mar, 08:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10094

  3. Christian Kuhn uploaded patch set 2 03/12/21, 20:26

  4. core-ci voted on patch set 1 V -1 03/12/21, 20:26 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1471

  5. TYPO3com voted on patch set 2 V -1 03/12/21, 20:34 Completed build in 08m 21s on Fri, 12 Mar, 08:34 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10095

  6. core-ci voted on patch set 2 V -1 03/12/21, 20:36 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1472

  7. Christian Kuhn uploaded patch set 3 03/12/21, 20:41

  8. TYPO3com voted on patch set 3 V +1 03/12/21, 20:49 Completed build in 07m 38s on Fri, 12 Mar, 08:49 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10096

  9. core-ci voted on patch set 3 V +1 03/12/21, 20:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1473

  10. Anja Leichsenring commented on patch set 3 V +1 CR +1 03/13/21, 13:22

    Deprecation-93726-DeprecatedTypoScriptParserRelatedProperties.rst:30 Unresolved

    is very unlikely, probably?
  11. Andreas Kienast commented on patch set 3 CR -1 03/13/21, 14:33

    Deprecation-93726-DeprecatedTypoScriptParserRelatedProperties.rst:18 Unresolved

    I think you mean `ext_config_BRP`? Needs to be fixed in the matcher as well.
  12. Andreas Kienast uploaded patch set 4 03/13/21, 14:35

  13. Andreas Kienast voted on patch set 4 V +1 CR +1 03/13/21, 14:36

  14. TYPO3com voted on patch set 4 V +1 03/13/21, 14:43 Completed build in 07m 48s on Sat, 13 Mar, 02:43 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10103

  15. core-ci voted on patch set 4 V +1 03/13/21, 14:49 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1486

  16. Anja Leichsenring voted on patch set 4 V +2 CR +2 03/14/21, 15:45

  17. Anja Leichsenring merged patch set 5 03/14/21, 15:45