Review main Merged

68373[BUGFIX] Remove maxitems constraint from be_groups.pagetypes_select

Andreas Kienast CR +2 V +2 Easy +0 −2 updated 03/14/21, 10:23

Commit message

The field be_groups.pagetypes_select is of type TEXT, which can contain
data of a maximum of 64 kilobytes. This patch removes the maxitems
constraint pinned to 20 items as a page type identifier usually is a few
bytes long.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Guido Schmechel +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Guido Schmechel +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Andreas Kienast uploaded patch set 1 03/13/21, 14:22

  2. TYPO3com voted on patch set 1 V +1 03/13/21, 14:30 Completed build in 08m 13s on Sat, 13 Mar, 02:30 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10102

  3. core-ci voted on patch set 1 V +1 03/13/21, 14:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1485

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 03/13/21, 14:35

  5. Guido Schmechel voted on patch set 1 V +1 CR +1 03/13/21, 15:44

  6. Oli Bartsch voted on patch set 1 V +1 CR +1 03/13/21, 21:58

  7. Christian Kuhn voted on patch set 1 V +1 CR +1 03/13/21, 22:22

  8. Christian Kuhn voted on patch set 1 V +2 CR +2 03/14/21, 10:23

  9. Christian Kuhn merged patch set 2 03/14/21, 10:23