Review 10.4 Merged

68424[SECURITY] XSS in PreviewRenderer with descriptions

Oliver Hader CR +2 V +2 Easy +1 −1 updated 03/16/21, 09:48

Commit message

The PreviewRenderer pattern introduced with #78450 makes use of the TCA
feature `descriptionColumn` to render the content of this column in a
content element's preview in the page module.

The content of the column however was not properly escaped allowing
a persistent XSS abuse.

This patch adds a `htmlspecialchars()` to the output to escape the
content properly

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 2

Files 1

Review log 35

  1. Oliver Hader uploaded patch set 1 03/16/21, 09:01

  2. Oliver Hader commented on patch set 1 V +2 CR +2 03/16/21, 09:01

    Auto-approved
  3. Oliver Hader merged patch set 2 03/16/21, 09:01

  4. TYPO3com voted on patch set 1 V +1 03/16/21, 09:36 Completed build in 30m 33s on Tue, 16 Mar, 09:36 AM Test Summary: 75958 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1231

  5. core-ci voted on patch set 1 V +1 03/16/21, 09:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1580