Review main Merged

68434[SECURITY] Prevent urls starting with // to be used for redirects

Oliver Hader CR +2 V +2 Easy +42 −2 updated 03/16/21, 09:37

Commit message

A missing check in GeneralUtility::sanitizeLocalUrl() resulted in
an url starting with `//` to be considered as a local url.

This change ensures, that urls starting with `//` are not considered
local. Corresponding unit tests are fixed and extended, since they
need a full environment to process correctly.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 03/16/21, 09:04

  2. Oliver Hader commented on patch set 1 V +2 CR +2 03/16/21, 09:04

    Auto-approved
  3. Oliver Hader merged patch set 2 03/16/21, 09:04

  4. TYPO3com voted on patch set 1 V +1 03/16/21, 09:37 Completed build in 31m 38s on Tue, 16 Mar, 09:37 AM Test Summary: 32717 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10148