Review main Merged

68453[SECURITY] Mitigate XSS in PreviewRenderer for menus

Oliver Hader CR +2 V +2 Easy +2 −2 updated 03/16/21, 09:39

Commit message

The content element preview for menus displays the
menu type label along with the record title of the
defined pages and categories. Since the output was
not properly encoded, this led to a XSS vulnerability
in the page module.

The issue is addressed by properly encoding user input.

Note: Because of a bug in `PreviewRenderer`, the
vulnerable code was most likely not executed in any
TYPO3 installation after v8.6.0.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 1

Review log 3

  1. Oliver Hader uploaded patch set 1 03/16/21, 09:39

  2. Oliver Hader commented on patch set 1 V +2 CR +2 03/16/21, 09:39

    Auto-approved
  3. Oliver Hader merged patch set 2 03/16/21, 09:39