Review main Merged

68456[FEATURE] Add "collapse all" and secondary menu for all trees

Benni Mack CR +2 V +2 Normal +160 −53 updated 08/30/21, 20:02

Commit message

This change introduces a "secondary menu" for all
trees and moves the "reload tree" into the secondary
menu. In addition, a new icon "Collapse All" is introduced
to be in line with the FormEngine Tree Renderer to also
have this feature available in all SVG-based trees.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 4

Files 13

Review log 2033

Show 58 earlier messages
  1. Benni Mack uploaded patch set 1 03/16/21, 10:08

  2. TYPO3com voted on patch set 1 V -1 03/16/21, 10:17 Completed build in 09m 35s on Tue, 16 Mar, 10:17 AM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10158

  3. core-ci voted on patch set 1 V +1 03/16/21, 10:21 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1592

  4. Nicole Hummel commented on patch set 1 03/16/21, 12:07

    PageTreeElement.ts:258 Unresolved

    What do you think of first filter all nodes and closing only expanded ones? filter(function(node) { return node.expanded })

    FileStorageTreeContainer.ts:163 Unresolved

    What do you think of first filter all nodes and closing only expanded ones? filter(function(node) { return node.expanded })
  5. Nicole Hummel voted on patch set 1 V +1 03/16/21, 12:07

  6. Benni Mack uploaded patch set 2 08/04/21, 13:28

  7. core-ci voted on patch set 2 V -1 08/04/21, 13:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14089

  8. Benni Mack uploaded patch set 3 08/24/21, 09:13

  1. core-ci voted on patch set 3 V +1 08/24/21, 09:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15483

  2. Benni Mack uploaded patch set 4 08/24/21, 14:50

  3. core-ci voted on patch set 4 V +1 08/24/21, 15:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15519

  4. Benni Mack uploaded patch set 5 08/30/21, 09:30

  5. core-ci voted on patch set 5 V -1 08/30/21, 09:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15848

  6. Benni Mack uploaded patch set 6 08/30/21, 10:56

  7. core-ci voted on patch set 6 V -1 08/30/21, 11:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15855

  8. Benni Mack uploaded patch set 7 08/30/21, 11:20

  9. core-ci voted on patch set 7 V -1 08/30/21, 11:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15856

  10. Benni Mack uploaded patch set 8 08/30/21, 13:57

  11. Benni Mack uploaded patch set 9 08/30/21, 14:16

  12. core-ci voted on patch set 8 V -1 08/30/21, 14:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15866

  13. core-ci voted on patch set 9 V -1 08/30/21, 14:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15867

  14. Benni Mack uploaded patch set 10 08/30/21, 14:32

  15. Benni Mack uploaded patch set 11 08/30/21, 14:35

  16. core-ci voted on patch set 10 V -1 08/30/21, 14:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15870

  17. core-ci voted on patch set 11 V +1 08/30/21, 14:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15871

  18. Michael Schams voted on patch set 11 V +1 08/30/21, 15:07

  19. Oli Bartsch voted on patch set 11 V +1 CR +1 08/30/21, 15:39

  20. Benni Mack uploaded patch set 12 08/30/21, 17:55

  21. core-ci voted on patch set 12 V +1 08/30/21, 18:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15889

  22. Jochen Roth voted on patch set 12 V +1 CR +1 08/30/21, 18:13

  23. Oli Bartsch voted on patch set 12 V +1 CR +1 08/30/21, 19:03

  24. Benni Mack voted on patch set 12 V +2 CR +2 08/30/21, 20:01

  25. Benni Mack merged patch set 13 08/30/21, 20:02