Review main Merged

68463[TASK] Disable PHP 8 functional testing

Christian Kuhn CR +2 V +2 Easy +4 −3 updated 03/16/21, 13:54

Commit message

The recent extbase related class schema revert
introduced a warning within functional PHP 8
tests leading to test fails.
Run the mariadb functionals with PHP 7.4 instead
of PHP 8 for the moment again.
Additionally a minor type hint from one of the
recent security patches is added in ext:form
area to make phpstan happy again.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 2

Review log 510

  1. Christian Kuhn uploaded patch set 1 03/16/21, 12:49

  2. TYPO3com voted on patch set 1 V -1 03/16/21, 12:57 Completed build in 08m 21s on Tue, 16 Mar, 12:57 PM Test Summary: 29336 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10160

  3. core-ci voted on patch set 1 V -1 03/16/21, 12:59 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1597

  4. Christian Kuhn uploaded patch set 2 03/16/21, 13:12

  5. TYPO3com voted on patch set 2 V -1 03/16/21, 13:20 Completed build in 07m 32s on Tue, 16 Mar, 01:20 PM Test Summary: 31693 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10161

  6. core-ci voted on patch set 2 V +1 03/16/21, 13:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1598

  7. TYPO3com voted on patch set 2 V +1 03/16/21, 13:43 Completed build in 38m 22s on Tue, 16 Mar, 01:43 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10161

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 03/16/21, 13:50

  9. Daniel Goerz voted on patch set 2 V +2 CR +2 03/16/21, 13:54

  10. Daniel Goerz merged patch set 3 03/16/21, 13:54