Review main Merged

68464[TASK] Use native DOM events instead of d3

Benni Mack CR +2 V +2 Hard +375 −396 updated 06/05/21, 14:41

Commit message

This change reduces the overhead of the d3 framework
by using native CustomEvents on the actual Lit element
of the SVG instead of d3-dispatch logic:

* typo3:svg-tree:nodes-prepared (enrich node data)
* typo3:svg-tree:expand-toggle (expand/collapse)
* typo3:svg-tree:node-context (clickmenu)
* typo3:svg-tree:node-selected (on-click)

As shown in the patch, the actual logic of interacting
with the outside framework (Persistent, ContextMenu, window.)
is moved to the actual Lit components, making the SVG
tree slimmer and easier to maintain.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Georg Ringer +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 14

Review log 1229

Show 24 earlier messages
  1. Benni Mack uploaded patch set 1 03/16/21, 13:30

  2. TYPO3com voted on patch set 1 V -1 03/16/21, 13:37 Completed build in 06m 23s on Tue, 16 Mar, 01:37 PM Test Summary: 30127 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10162

  3. Benni Mack uploaded patch set 2 03/16/21, 13:39

  4. core-ci voted on patch set 1 V -1 03/16/21, 13:43 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1599

  1. TYPO3com voted on patch set 2 V -1 03/16/21, 13:47 Completed build in 07m 19s on Tue, 16 Mar, 01:46 PM Test Summary: 32098 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10163

  2. core-ci voted on patch set 2 V -1 03/16/21, 13:56 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1600

  3. Benni Mack rebased onto patch set 3 03/16/21, 14:09

  4. TYPO3com voted on patch set 3 V -1 03/16/21, 14:17 Completed build in 07m 08s on Tue, 16 Mar, 02:17 PM Test Summary: 31711 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10165

  5. core-ci voted on patch set 3 V +1 03/16/21, 14:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1602

  6. TYPO3com voted on patch set 3 V +1 03/16/21, 14:23 Completed build in 20m 23s on Tue, 16 Mar, 02:23 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10165

  7. Benni Mack uploaded patch set 4 03/16/21, 14:57

  8. TYPO3com voted on patch set 4 V +1 03/16/21, 15:04 Completed build in 06m 51s on Tue, 16 Mar, 03:04 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10167

  9. core-ci voted on patch set 4 V +1 03/16/21, 15:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1604

  10. Benni Mack uploaded patch set 5 03/19/21, 09:50

  11. TYPO3com voted on patch set 5 V +1 03/19/21, 09:57 Completed build in 06m 59s on Fri, 19 Mar, 09:57 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10229

  12. core-ci voted on patch set 5 V +1 03/19/21, 10:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1687

  13. Benni Mack uploaded patch set 6 03/19/21, 10:27

  14. TYPO3com voted on patch set 6 V +1 03/19/21, 10:35 Completed build in 07m 40s on Fri, 19 Mar, 10:35 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10230

  15. core-ci voted on patch set 6 V -1 03/19/21, 10:38 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1688

  16. Benni Mack uploaded patch set 7 03/19/21, 11:59

  17. Benni Mack updated the commit message in patch set 8 03/19/21, 11:59

  18. TYPO3com voted on patch set 7 V +1 03/19/21, 12:07 Completed build in 07m 50s on Fri, 19 Mar, 12:07 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10232

  19. TYPO3com voted on patch set 8 V +1 03/19/21, 12:07 Completed build in 07m 59s on Fri, 19 Mar, 12:07 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10233

  20. core-ci voted on patch set 7 V +1 03/19/21, 12:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1690

  21. core-ci voted on patch set 8 V +1 03/19/21, 12:15 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1691

  22. Georg Ringer voted on patch set 8 V +1 CR +1 03/19/21, 13:06

  23. Richard Haeser voted on patch set 8 V +2 CR +2 03/19/21, 13:31

  24. Richard Haeser merged patch set 9 03/19/21, 13:31

  25. Daniel Goerz commented on patch set 9 06/05/21, 14:41

    This patch introduced a regression: https://forge.typo3.org/issues/94281