Review 9.5 Merged

68465[BUGFIX] Missing class import in FileReference

Christian Kuhn CR +2 V +2 Easy +1 −0 updated 03/17/21, 15:11

Commit message

One of the recent security patches missed a class
import in v9. v10 and v11.1 are not affected and
phpstan would have found such an issue in >v10, too.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Ingo Fabbri +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Andreas Kienast +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 1

Review log 1418

  1. Christian Kuhn uploaded patch set 1 03/16/21, 16:00

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 03/16/21, 16:01

  3. TYPO3com voted on patch set 1 V +1 03/16/21, 16:11 Completed build in 11m 26s on Tue, 16 Mar, 04:11 PM Test Summary: 75790 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1038

  4. core-ci voted on patch set 1 V +1 03/16/21, 16:13 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1607

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 03/16/21, 16:24

  6. Guido Schmechel voted on patch set 1 CR +1 03/16/21, 16:27

  7. Oliver Hader voted on patch set 1 CR +1 03/16/21, 16:33

  8. Daniel Goerz commented on patch set 1 03/16/21, 17:30

    It's rather a BUGFIX, right?
  9. Christian Kuhn commented on patch set 1 03/16/21, 17:51

    Reply

    oh yes.
  10. Christian Kuhn updated the commit message in patch set 2 03/16/21, 17:51

  11. Andreas Kienast voted on patch set 2 V +1 CR +1 03/16/21, 17:55

  12. Daniel Goerz voted on patch set 2 V +1 CR +1 03/16/21, 17:57

  13. Oli Bartsch voted on patch set 2 V +1 CR +1 03/16/21, 17:57

  14. TYPO3com voted on patch set 2 V +1 03/16/21, 18:03 Completed build in 11m 17s on Tue, 16 Mar, 06:03 PM Test Summary: 75790 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1039

  15. core-ci voted on patch set 2 V +1 03/16/21, 18:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1608

  16. Christian Kuhn voted on patch set 2 V +2 CR +2 03/16/21, 18:29

  17. Christian Kuhn merged patch set 3 03/16/21, 18:29

  18. Ingo Fabbri voted on patch set 3 CR +1 03/17/21, 15:11