Review main Merged

68468[TASK] Deprecate sys_language database table

Benni Mack CR +2 V +2 Hard +236 −94 updated 05/25/21, 16:47

Commit message

The database table sys_language has become obsolete
with the introduction of site handling and site
languages. Since language configuration is not
content, it does not have to be included system-wide
in the database. Therefore the table is now marked
as deprecated and not referenced in the Core anymore.

This means, that this patch removes any direct usages
of sys_language in the core, except the site configuration
module, as this requires an overall rework of how site
languages can be created and pre-filled in the GUI and is
therefore handled in a separate patch.

This also enables us to possibly use locales (and unify
the typo3 languages to locales) for content in the future.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2754

Show 1329 earlier messages
  1. Benni Mack uploaded patch set 1 03/17/21, 07:26

  2. TYPO3com voted on patch set 1 V -1 03/17/21, 07:33 Completed build in 07m 05s on Wed, 17 Mar, 07:33 AM Test Summary: 503 of 33143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10176

  3. core-ci voted on patch set 1 V -1 03/17/21, 07:45 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1619

  4. Benni Mack rebased onto patch set 2 04/19/21, 20:26

  5. TYPO3com voted on patch set 2 V -1 04/19/21, 20:33 Completed build in 06m 53s on Mon, 19 Apr, 08:33 PM Test Summary: 536 of 33543 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10743

  6. core-ci voted on patch set 2 V -1 04/19/21, 20:48 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2351

  7. Oli Bartsch uploaded patch set 3 04/20/21, 10:56

  8. TYPO3com voted on patch set 3 V -1 04/20/21, 11:03 Completed build in 07m 25s on Tue, 20 Apr, 11:03 AM Test Summary: 30 of 33543 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10753

  9. Oli Bartsch uploaded patch set 4 04/20/21, 11:46

  10. TYPO3com voted on patch set 4 V -1 04/20/21, 11:53 Completed build in 07m 22s on Tue, 20 Apr, 11:53 AM Test Summary: 18 of 33543 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10755

  11. core-ci voted on patch set 3 V -1 04/20/21, 12:02 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2364

  12. core-ci voted on patch set 4 V -1 04/20/21, 12:04 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2366

  13. Oli Bartsch rebased onto patch set 5 04/26/21, 22:40

  14. core-ci voted on patch set 5 V -1 04/26/21, 22:57 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10719

  15. Oli Bartsch uploaded patch set 6 04/26/21, 23:35

  16. core-ci voted on patch set 6 V +1 04/26/21, 23:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10720

  17. Oli Bartsch uploaded patch set 7 04/27/21, 10:05

  18. core-ci voted on patch set 7 V +1 04/27/21, 10:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10728

  19. Benni Mack uploaded patch set 8 04/27/21, 11:50

  20. core-ci voted on patch set 8 V +1 04/27/21, 12:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10732

  21. Oli Bartsch uploaded patch set 9 05/03/21, 15:17

  22. core-ci voted on patch set 9 V +1 05/03/21, 15:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11054

  23. Oli Bartsch uploaded patch set 10 05/03/21, 16:38

  24. core-ci voted on patch set 10 V -1 05/03/21, 16:39 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11056

  25. Oli Bartsch uploaded patch set 11 05/12/21, 12:06

  26. core-ci voted on patch set 11 V -1 05/12/21, 12:21 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11433

  27. Oli Bartsch uploaded patch set 12 05/12/21, 13:02

  28. core-ci voted on patch set 12 V +1 05/12/21, 13:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11434

  29. Oli Bartsch uploaded patch set 13 05/13/21, 23:08

  1. core-ci voted on patch set 13 V -1 05/13/21, 23:17 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11487

  2. Benni Mack uploaded patch set 14 05/14/21, 15:36

  3. core-ci voted on patch set 14 V -1 05/14/21, 15:48 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11524

  4. Oli Bartsch uploaded patch set 15 05/17/21, 19:50

  5. core-ci voted on patch set 15 V -1 05/17/21, 20:03 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11598

  6. Oli Bartsch uploaded patch set 16 05/17/21, 21:05

  7. core-ci voted on patch set 16 V +1 05/17/21, 21:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11601

  8. Oli Bartsch uploaded patch set 17 05/19/21, 21:40

  9. core-ci voted on patch set 17 V +1 05/19/21, 21:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11688

  10. Oli Bartsch uploaded patch set 18 05/19/21, 23:49

  11. core-ci voted on patch set 18 V +1 05/20/21, 00:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11690

  12. Georg Ringer updated the commit message in patch set 19 05/20/21, 05:51

  13. core-ci voted on patch set 19 V +1 05/20/21, 06:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11694

  14. Benni Mack uploaded patch set 20 05/25/21, 09:13

  15. Oli Bartsch uploaded patch set 21 05/25/21, 09:21

  16. core-ci voted on patch set 20 V +1 05/25/21, 09:26 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11817

  17. Oli Bartsch uploaded patch set 22 05/25/21, 09:28

  18. core-ci voted on patch set 21 V +1 05/25/21, 09:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11818

  19. Oli Bartsch updated the commit message in patch set 23 05/25/21, 09:33

  20. core-ci voted on patch set 22 V +1 05/25/21, 09:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11819

  21. core-ci voted on patch set 23 V +1 05/25/21, 09:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11822

  22. Benni Mack voted on patch set 23 V +1 CR +1 05/25/21, 10:20

  23. Jochen Roth voted on patch set 23 V +1 CR +1 05/25/21, 15:57

  24. Benni Mack voted on patch set 23 V +2 CR +2 05/25/21, 16:47

  25. Benni Mack merged patch set 24 05/25/21, 16:47