Review main Merged

68470[BUGFIX] Use active tab in link for tabs in Element Browser

Benni Mack CR +2 V +2 Easy +2 −2 updated 03/17/21, 11:14

Commit message

The element browser now shows the active state
again of the tab (Page, File, Folder etc), because the
active class needs to reside on the link and not on the <li>
element.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Georg Ringer +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 59

  1. Benni Mack uploaded patch set 1 03/17/21, 10:34

  2. TYPO3com voted on patch set 1 V +1 03/17/21, 10:41 Completed build in 07m 01s on Wed, 17 Mar, 10:41 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10180

  3. core-ci voted on patch set 1 V +1 03/17/21, 10:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1624

  4. Georg Ringer uploaded patch set 2 03/17/21, 10:52

  5. Georg Ringer voted on patch set 2 V +1 CR +1 03/17/21, 10:52

  6. TYPO3com voted on patch set 2 V +1 03/17/21, 10:59 Completed build in 06m 50s on Wed, 17 Mar, 10:59 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10181

  7. core-ci voted on patch set 2 V +1 03/17/21, 11:03 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1625

  8. Richard Haeser voted on patch set 2 V +2 CR +2 03/17/21, 11:14

  9. Richard Haeser merged patch set 3 03/17/21, 11:14