Review main Merged

68471[BUGFIX] Set active class on link of initially active tab

Oli Bartsch CR +2 V +2 Easy +8 −8 updated 03/17/21, 12:05

Commit message

Since bootstrap 5 an active tab is highlighted by setting the
`.active` class on the tab item link (`.nav-link`) instead of
the tab item (`.nav-item`) itself.

Therefore, this must also be done in templates defining the
initially active tab item, which is usually just the first one.

See: https://getbootstrap.com/docs/5.0/components/navs-tabs/#fill-and-justify

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 4

Review log 46

  1. Oli Bartsch uploaded patch set 1 03/17/21, 11:14

  2. TYPO3com voted on patch set 1 V +1 03/17/21, 11:22 Completed build in 07m 41s on Wed, 17 Mar, 11:22 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10182

  3. core-ci voted on patch set 1 V +1 03/17/21, 11:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1626

  4. Benni Mack voted on patch set 1 V +1 CR +1 03/17/21, 11:55

  5. Richard Haeser voted on patch set 1 V +2 CR +2 03/17/21, 12:05

  6. Richard Haeser merged patch set 2 03/17/21, 12:05