Review main Merged

68492[BUGFIX] Normalize slug before converting Unicode characters to ascii

Dmitry Dulepov CR +2 V +2 Easy +19 −8 updated 05/11/21, 20:02

Commit message

This change adds a normalization for slug source before converting it
to ascii. This helps to avoid issues with various ways to encode the
same Unicode characters.

Used command:
   composer req symfony/polyfill-intl-normalizer

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2035

Show 510 earlier messages
  1. Dmitry Dulepov uploaded patch set 1 03/17/21, 12:13

  2. TYPO3com voted on patch set 1 V -1 03/17/21, 12:20 Completed build in 07m 10s on Wed, 17 Mar, 12:20 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10184

  3. core-ci voted on patch set 1 V -1 03/17/21, 12:23 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1627

  4. Dmitry Dulepov uploaded patch set 2 03/17/21, 12:27

  5. Dmitry Dulepov uploaded patch set 3 03/17/21, 12:30

  6. TYPO3com voted on patch set 2 V -1 03/17/21, 12:34 Completed build in 07m 05s on Wed, 17 Mar, 12:34 PM Test Summary: 2 of 33145 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10185

  7. TYPO3com voted on patch set 3 V -1 03/17/21, 12:38 Completed build in 07m 14s on Wed, 17 Mar, 12:37 PM Test Summary: 2 of 33145 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10186

  8. Dmitry Dulepov uploaded patch set 4 03/17/21, 12:38

  9. core-ci voted on patch set 2 V -1 03/17/21, 12:39 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1628

  10. Dmitry Dulepov uploaded patch set 5 03/17/21, 12:44

  1. core-ci voted on patch set 3 V -1 03/17/21, 12:44 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1629

  2. TYPO3com voted on patch set 4 V +1 03/17/21, 12:46 Completed build in 07m 04s on Wed, 17 Mar, 12:46 PM Test Summary: 32909 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10187

  3. TYPO3com voted on patch set 5 V +1 03/17/21, 12:51 Completed build in 06m 40s on Wed, 17 Mar, 12:51 PM Test Summary: 32909 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10188

  4. core-ci voted on patch set 4 V +1 03/17/21, 12:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1630

  5. core-ci voted on patch set 5 V +1 03/17/21, 12:56 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1631

  6. Mathias Brodala commented on patch set 5 CR -1 03/17/21, 13:17

    SlugHelper.php:117 Unresolved

    "ext-intl" is not a mandatory dependency of TYPO3 yet so we cannot rely on this class. So we need to add https://packagist.org/packages/symfony/polyfill-intl-normalizer as dependency at least.
  7. Mathias Brodala commented on patch set 5 03/17/21, 13:18

    Unresolved

    TYPO3v9 only gets priority bugfixes by now so this should be removed.
  8. Dmitry Dulepov uploaded patch set 6 03/17/21, 14:07

  9. TYPO3com voted on patch set 6 V +1 03/17/21, 14:14 Completed build in 06m 54s on Wed, 17 Mar, 02:14 PM Test Summary: 32909 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10190

  10. Mathias Brodala voted on patch set 6 CR +1 03/17/21, 14:17

  11. core-ci voted on patch set 6 V +1 03/17/21, 14:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1633

  12. Guido Schmechel voted on patch set 6 CR +1 03/19/21, 16:56

  13. Anja Leichsenring rebased onto patch set 7 05/04/21, 18:44

  14. core-ci voted on patch set 7 V +1 05/04/21, 18:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11150

  15. Daniel Goerz commented on patch set 7 CR -1 05/04/21, 18:57

    composer.json:58 Unresolved

    This needs to go into root composer.json as well
  16. Anja Leichsenring uploaded patch set 8 05/04/21, 19:00

  17. core-ci voted on patch set 8 V +1 05/04/21, 19:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11152

  18. Daniel Goerz voted on patch set 8 CR +1 05/04/21, 19:21

  19. Anja Leichsenring voted on patch set 8 V +1 CR +1 05/04/21, 19:24

  20. Anja Leichsenring uploaded patch set 9 05/11/21, 19:23

  21. Anja Leichsenring voted on patch set 9 V +1 CR +1 05/11/21, 19:29

  22. core-ci voted on patch set 9 V +1 05/11/21, 19:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11399

  23. Daniel Goerz voted on patch set 9 V +1 CR +1 05/11/21, 20:01

  24. Anja Leichsenring voted on patch set 9 V +2 CR +2 05/11/21, 20:02

  25. Anja Leichsenring merged patch set 10 05/11/21, 20:02