Review main Merged

68493[BUGFIX] Use correct type for cache compression setting in install tool

Markus Klein CR +2 V +2 Easy +4 −4 updated 03/17/21, 14:59

Commit message

The DatabaseCachePreset now sets options/compression to `true` instead
of 1. This is necessary because the option is of type boolean in the
backend code.
This fails hard if the backend is validating the option, like the Redis
backend does.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Markus Klein uploaded patch set 1 03/17/21, 14:40

  2. TYPO3com voted on patch set 1 V +1 03/17/21, 14:47 Completed build in 07m 23s on Wed, 17 Mar, 02:47 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10191

  3. core-ci voted on patch set 1 V +1 03/17/21, 14:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1634

  4. Benni Mack voted on patch set 1 V +1 CR +1 03/17/21, 14:59

  5. Benni Mack voted on patch set 1 V +2 CR +2 03/17/21, 14:59

  6. Benni Mack merged patch set 2 03/17/21, 14:59