Review 10.4 Abandoned

68494[BUGFIX] Check for TYPO3_REQUEST before using DeferredBackendImgProcessor

Stefan Froemken CR 0 V 0 Easy +3 −1 updated 04/12/21, 20:03

Commit message

With activated emailMeAtLogin the DeferredBackendImageProcessor
will be used to render the images in FluidMail. As this processor
relates on UriBuilder and LocalizationService the image processing will
fail, because LocalizationService is not set until now.

We prevent using the DeferredBackendImageProcessor in order to check
against a configured TYPO3_REQUEST now.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 713

  1. Stefan Froemken uploaded patch set 1 03/17/21, 15:18

  2. Stefan Froemken commented on patch set 1 03/17/21, 15:22

    This is the same solution like Christian Kuhn has done in related issue (Replace TYPO3_MODE).
  3. Stefan Froemken updated the commit message in patch set 2 03/17/21, 15:28

  4. TYPO3com voted on patch set 1 V -1 03/17/21, 15:30 Completed build in 11m 28s on Wed, 17 Mar, 03:30 PM Test Summary: 75969 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1239

  5. Markus Klein commented on patch set 2 03/17/21, 15:31

    Unresolved

    master too?
  6. core-ci voted on patch set 1 V -1 03/17/21, 15:32 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1637

  7. TYPO3com voted on patch set 2 V -1 03/17/21, 15:38 Completed build in 09m 51s on Wed, 17 Mar, 03:38 PM Test Summary: 75969 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1240

  8. core-ci voted on patch set 2 V -1 03/17/21, 15:39 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1638

  9. Stefan Froemken uploaded patch set 3 03/17/21, 15:46

  10. TYPO3com voted on patch set 3 V +1 03/17/21, 15:57 Completed build in 10m 42s on Wed, 17 Mar, 03:57 PM Test Summary: 75968 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1241

  11. core-ci voted on patch set 3 V +1 03/17/21, 15:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1639

  12. Helmut Hummel commented on patch set 3 CR -1 03/24/21, 14:09

    I'd suggest to rather go with this change: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68518
  13. Stefan Froemken abandoned the change 04/12/21, 20:03

    Solved with Patch of Helmut. He removes the usage of ImgProcessor