Review main Merged

68495[BUGFIX] Fix Toolbar links when Topbar is refreshed

Benjamin Franzke CR +2 V +2 Easy +2 −2 updated 03/18/21, 08:40

Commit message

Whenever a topbar refresh is triggered, e.g. by activating/deactivating
of an extension in the extension manager, or when changing the backend
users language, the topbar link events (such as "user settings") need
to be re-added.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Michael Telgkamp +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 2

Review log 1016

  1. Benjamin Franzke uploaded patch set 1 03/17/21, 18:09

  2. TYPO3com voted on patch set 1 V +1 03/17/21, 18:16 Completed build in 07m 10s on Wed, 17 Mar, 06:16 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10195

  3. core-ci voted on patch set 1 V -1 03/17/21, 18:20 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1642

  4. Oli Bartsch uploaded patch set 2 03/17/21, 20:26

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 03/17/21, 20:27

  6. TYPO3com commented on patch set 2 03/17/21, 20:35 Completed build in 08m 51s on Wed, 17 Mar, 08:35 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10198

  7. core-ci commented on patch set 2 03/17/21, 20:37 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1645

  8. Oli Bartsch commented on patch set 2 V 0 CR -1 03/17/21, 22:48

    The failing test is real. Didn't expect this, since Bamboo is green. But as Christian mentioned, Bamboo does not perform any acceptance test at the moment. The problem for the failing tests: The "Minimize/Maximize module menu" toggle does not longer work.
  9. Benjamin Franzke commented on patch set 2 03/18/21, 08:04

    Reply

    Ah, right, I oversaw that Viewport.Topbar.Toolbar.registerEvent calls the callback synchrously once, that means we had the event handlers (initially) registered twice, resulting in double toggle, therefore no change. Will fix.
  10. Benjamin Franzke uploaded patch set 3 03/18/21, 08:05

  11. Michael Telgkamp voted on patch set 3 V +1 CR +1 03/18/21, 08:10

  12. TYPO3com voted on patch set 3 V +1 03/18/21, 08:12 Completed build in 07m 19s on Thu, 18 Mar, 08:12 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10207

  13. core-ci voted on patch set 3 V +1 03/18/21, 08:15 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1659

  14. Oli Bartsch voted on patch set 3 V +1 CR +1 03/18/21, 08:23

  15. Benjamin Franzke voted on patch set 3 V +2 CR +2 03/18/21, 08:40

  16. Benjamin Franzke merged patch set 4 03/18/21, 08:40