68496[WIP][TASK] Render TS and pageTS snippets with FormEngine
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 16
- Build/Sources/Sass/editor.scss+6 −0
- Build/Sources/TypeScript/t3editor/Resources/Public/TypeScript/Element/CodeMirrorElement.ts+17 −1
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+27 −13
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js+21 −19
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+6 −240
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+0 −95
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+37 −8
- typo3/sysext/info/Resources/Private/Partials/PageTsConfig/Page.html+1 −8
- typo3/sysext/t3editor/Classes/Form/Element/T3editorElement.php+31 −2
- typo3/sysext/t3editor/Resources/Public/Css/t3editor.css+1 −1
- typo3/sysext/t3editor/Resources/Public/JavaScript/Element/CodeMirrorElement.js+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerModuleFunctionController.php+143 −118
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php+1 −1
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_analyzer.xlf+0 −21
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateAnalyzerModuleFunction.html+6 −24
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateObjectBrowserModuleFunction.html+1 −1
Review log 1122
-
Christian Kuhn uploaded patch set 1 03/17/21, 20:41
-
TYPO3com voted on patch set 1 V -1 03/17/21, 20:41 Completed build in 18s on Wed, 17 Mar, 08:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10199
-
Christian Kuhn uploaded patch set 2 03/17/21, 20:41
-
core-ci voted on patch set 1 V -1 03/17/21, 20:43 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1646
-
TYPO3com voted on patch set 2 V +1 03/17/21, 20:49 Completed build in 07m 33s on Wed, 17 Mar, 08:49 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10200
-
core-ci voted on patch set 2 V +1 03/17/21, 20:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1647
-
Oli Bartsch uploaded patch set 3 04/07/21, 08:32
-
TYPO3com voted on patch set 3 V +1 04/07/21, 08:39 Completed build in 07m 15s on Wed, 7 Apr, 08:39 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10517
-
core-ci voted on patch set 3 V +1 04/07/21, 08:44 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2069
-
Oli Bartsch uploaded patch set 4 04/07/21, 15:39
-
TYPO3com voted on patch set 4 V +1 04/07/21, 15:46 Completed build in 06m 55s on Wed, 7 Apr, 03:46 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10524
-
core-ci voted on patch set 4 V -1 04/07/21, 15:50 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2076
-
Oli Bartsch uploaded patch set 5 04/07/21, 16:10
-
TYPO3com voted on patch set 5 V +1 04/07/21, 16:18 Completed build in 07m 22s on Wed, 7 Apr, 04:18 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10525
-
core-ci voted on patch set 5 V +1 04/07/21, 16:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2077
-
Benni Mack commented on patch set 5 CR -1 04/27/21, 20:22
no Releases and no Resolves line. Can't be merged like this. -
Christian Kuhn uploaded patch set 6 05/05/21, 13:26
-
Christian Kuhn commented on patch set 6 05/05/21, 13:26
rebased for now -
core-ci voted on patch set 6 V +1 05/05/21, 13:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11212
-
Benjamin Franzke commented on patch set 6 05/13/21, 00:13
Here is an alternative POC that uses our codemirror webcomponent directly, instead of creating a fake FormEngine for these non-Form views: Pushed as different changeset (credit/authorship of course goes to lolli), so we can compare and decide which route to follow: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69139 -
Christian Kuhn marked it work in progress 05/13/21, 12:49
-
Christian Kuhn abandoned the change 05/20/21, 12:25
abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/69139