Review main Abandoned

68496[WIP][TASK] Render TS and pageTS snippets with FormEngine

Christian Kuhn CR 0 V 0 Hard +299 −553 updated 05/20/21, 12:25

Commit message

@todo:
- see how to handle 'height' isses best
- extract the 'element' changes as feature patches.
- improve 't3editor not loaded' rendering

The TypoScript parser has a built in syntax hightlighter.
This is used by ext:tstemplate template analyzer and a sub
section of ext:info PageTsConfig.

We however have a much better syntax highlighter: t3editor.

The patch commits some long overdue love to the template
analyzer to use FormEngine rendering for TypoScript
snippets. t3editor kicks in if loaded, otherwise a textarea
is generated.

This allows to drop a metric ton of horky borky code from
TypoScriptParser and friends - enabling further refactorings
that may eventually end up with performance improvements
in some happy future?

Review

  • Code review CR 0
  • Verified V 0

Files 16

Review log 1122

  1. Christian Kuhn uploaded patch set 1 03/17/21, 20:41

  2. TYPO3com voted on patch set 1 V -1 03/17/21, 20:41 Completed build in 18s on Wed, 17 Mar, 08:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10199

  3. Christian Kuhn uploaded patch set 2 03/17/21, 20:41

  4. core-ci voted on patch set 1 V -1 03/17/21, 20:43 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1646

  5. TYPO3com voted on patch set 2 V +1 03/17/21, 20:49 Completed build in 07m 33s on Wed, 17 Mar, 08:49 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10200

  6. core-ci voted on patch set 2 V +1 03/17/21, 20:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1647

  7. Oli Bartsch uploaded patch set 3 04/07/21, 08:32

  8. TYPO3com voted on patch set 3 V +1 04/07/21, 08:39 Completed build in 07m 15s on Wed, 7 Apr, 08:39 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10517

  9. core-ci voted on patch set 3 V +1 04/07/21, 08:44 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2069

  10. Oli Bartsch uploaded patch set 4 04/07/21, 15:39

  11. TYPO3com voted on patch set 4 V +1 04/07/21, 15:46 Completed build in 06m 55s on Wed, 7 Apr, 03:46 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10524

  12. core-ci voted on patch set 4 V -1 04/07/21, 15:50 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2076

  13. Oli Bartsch uploaded patch set 5 04/07/21, 16:10

  14. TYPO3com voted on patch set 5 V +1 04/07/21, 16:18 Completed build in 07m 22s on Wed, 7 Apr, 04:18 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10525

  15. core-ci voted on patch set 5 V +1 04/07/21, 16:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2077

  16. Benni Mack commented on patch set 5 CR -1 04/27/21, 20:22

    no Releases and no Resolves line. Can't be merged like this.
  17. Christian Kuhn uploaded patch set 6 05/05/21, 13:26

  18. Christian Kuhn commented on patch set 6 05/05/21, 13:26

    rebased for now
  19. core-ci voted on patch set 6 V +1 05/05/21, 13:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11212

  20. Benjamin Franzke commented on patch set 6 05/13/21, 00:13

    Here is an alternative POC that uses our codemirror webcomponent directly, instead of creating a fake FormEngine for these non-Form views: Pushed as different changeset (credit/authorship of course goes to lolli), so we can compare and decide which route to follow: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69139
  21. Christian Kuhn marked it work in progress 05/13/21, 12:49

  22. Christian Kuhn abandoned the change 05/20/21, 12:25