Review main Abandoned

68499[WIP][FEATURE] Introduce generic record preview / listing

Benni Mack CR 0 V 0 Hard +272 −0 updated 11/05/21, 12:53

Commit message

ToDo:
* Ensure structure of JSON is stable / flexible
* Build subtype rendering
* Build generic record rendering as custom HTML element
* Resolve todos

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 711

  1. Benni Mack uploaded patch set 1 03/18/21, 07:51

  2. TYPO3com voted on patch set 1 V +1 03/18/21, 07:58 Completed build in 06m 58s on Thu, 18 Mar, 07:58 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10206

  3. core-ci voted on patch set 1 V +1 03/18/21, 08:01 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1658

  4. Benjamin Franzke commented on patch set 1 03/18/21, 08:15

    RecordListing.ts:28 Unresolved

    Better even in public connectedCallback(): void Note: that method then needs to call super.connectedCallback()
  5. Jonas Eberle commented on patch set 1 03/21/21, 09:39

    RecordListing.ts:58 Unresolved

    Would subtype rendering look like `<typo3-backend-render-entity table=... record=... representation=list shown-fields="*">` here? That customElement could use a global repository of registered renderers (TYPO3.settings.entityRenderers?) or fallback to `<typo3-backend-render-entity-default>`?
  6. Oliver Hader uploaded patch set 2 07/22/21, 13:58

  7. core-ci voted on patch set 2 V -1 07/22/21, 14:15 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13668

  8. Oliver Hader uploaded patch set 3 07/22/21, 14:16

  9. Oliver Hader commented on patch set 3 07/22/21, 14:16

    Just rebased...
  10. core-ci voted on patch set 3 V -1 07/22/21, 14:28 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13669

  11. Benni Mack abandoned the change 11/05/21, 12:53

    not working right now