Review main Merged

68516[TASK] Introduce id's to tables in list module

Lina Wolf CR +2 V +2 Easy +2 −9 updated 03/26/21, 12:45

Commit message

To simplify testing and screenshotting, each table listed
in the list module gets a unique id.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 713

  1. Lina Wolf uploaded patch set 1 03/18/21, 19:49

  2. TYPO3com voted on patch set 1 V +1 03/18/21, 19:57 Completed build in 07m 30s on Thu, 18 Mar, 07:57 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10220

  3. core-ci voted on patch set 1 V +1 03/18/21, 20:00 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1674

  4. Georg Ringer commented on patch set 1 03/18/21, 20:32

    can we have a class instead and use some prefix or suffix to know that those are meant for such stuff only? what do you think?
  5. Christian Kuhn uploaded patch set 2 03/26/21, 11:28

  6. Christian Kuhn commented on patch set 2 V +1 CR +1 03/26/21, 11:30

    Reply

    A prefix 't3-table-' is done. Semantically and id is correct here: There is always only one table listing per table name, so I think this is good to go.
  7. TYPO3com voted on patch set 2 V -1 03/26/21, 11:37 Completed build in 08m 28s on Fri, 26 Mar, 11:37 AM Test Summary: 31647 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10361

  8. core-ci voted on patch set 2 V +1 03/26/21, 11:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1851

  9. Oli Bartsch voted on patch set 2 V +1 CR +1 03/26/21, 11:46

  10. TYPO3com commented on patch set 2 03/26/21, 11:52 Completed build in 32m 40s on Fri, 26 Mar, 11:52 AM Test Summary: 32833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10361

  11. TYPO3com voted on patch set 2 V +1 03/26/21, 12:23 Completed build in 1h 27m 19s on Fri, 26 Mar, 12:23 PM Test Summary: 33239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10361

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 03/26/21, 12:45

  13. Christian Kuhn merged patch set 3 03/26/21, 12:45