Review main Merged

68517[TASK] Extend active evaluation of TOTP provider

Oli Bartsch CR +2 V +2 Normal +95 −41 updated 03/26/21, 11:39

Commit message

The TOTP provider is now only treated as active in case
the active flag is set and the shared secret exists.

It's actually really unlikely that no shared secret
exists, while the active flag is set, because this can
not be manipulated by a user, but only by an admin with
direct database access. However, since the TOTP provider
will never work without a shared secret, this property
is now also checked, to prevent unnecessary errors.

The corresponding tests are adjusted to check both
properties independently.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 4

Review log 1224

  1. Oli Bartsch uploaded patch set 1 03/18/21, 23:09

  2. TYPO3com voted on patch set 1 V +1 03/18/21, 23:16 Completed build in 06m 59s on Thu, 18 Mar, 11:16 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10225

  3. core-ci voted on patch set 1 V +1 03/18/21, 23:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1679

  4. Oli Bartsch uploaded patch set 2 03/18/21, 23:44

  5. TYPO3com voted on patch set 2 V +1 03/18/21, 23:52 Completed build in 08m 01s on Thu, 18 Mar, 11:52 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10226

  6. core-ci voted on patch set 2 V +1 03/18/21, 23:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1680

  7. Oli Bartsch uploaded patch set 3 03/25/21, 11:26

  8. TYPO3com voted on patch set 3 V -1 03/25/21, 11:35 Completed build in 08m 32s on Thu, 25 Mar, 11:35 AM Test Summary: 15 of 33041 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10345

  9. core-ci voted on patch set 3 V -1 03/25/21, 11:44 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1831

  10. Oli Bartsch uploaded patch set 4 03/25/21, 12:13

  11. TYPO3com voted on patch set 4 V -1 03/25/21, 12:20 Completed build in 06m 48s on Thu, 25 Mar, 12:20 PM Test Summary: 3 of 33440 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10346

  12. Oli Bartsch uploaded patch set 5 03/25/21, 12:26

  13. core-ci voted on patch set 4 V -1 03/25/21, 12:29 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1833

  14. TYPO3com voted on patch set 5 V +1 03/25/21, 12:34 Completed build in 07m 41s on Thu, 25 Mar, 12:34 PM Test Summary: 33204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10347

  15. core-ci voted on patch set 5 V +1 03/25/21, 12:36 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1834

  16. Christian Kuhn voted on patch set 5 V +1 CR +1 03/25/21, 12:42

  17. Jochen Roth voted on patch set 5 V +1 CR +1 03/25/21, 16:11

  18. Oli Bartsch commented on patch set 5 V -1 03/25/21, 16:42

    Have to think about this one again.
  19. Oli Bartsch uploaded patch set 6 03/25/21, 18:04

  20. TYPO3com voted on patch set 6 V +1 03/25/21, 18:11 Completed build in 07m 07s on Thu, 25 Mar, 06:11 PM Test Summary: 33239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10354

  21. core-ci voted on patch set 6 V +1 03/25/21, 18:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1841

  22. Jochen Roth voted on patch set 6 V +1 CR +1 03/25/21, 19:35

  23. Christian Kuhn voted on patch set 6 V +2 CR +2 03/26/21, 11:39

  24. Christian Kuhn merged patch set 7 03/26/21, 11:39