Review main Merged

68519[BUGFIX] Fix workspace pagination

Oli Bartsch CR +2 V +2 Normal +105 −13 updated 03/24/21, 17:00

Commit message

Since the workspace pagination took also child records
into account, which are however never being displayed
without their parent, the view broke as soon as such child
record would have been the first item on the next or the last
item on the previous page.

Therefore, the "total" count, used by the JavaScript pagination
to calculate the amount of pages, does not longer take any
child records into account.

The data array, containing the records for the requested page,
is now filled until the limit of records is reached with only parent
records. Therefore, the actual record items count can differ from
the proposed limit, since the child records are added without
increasing the corresponding counter.

The same functionality does also take place on calculation of the
offset value. This means, the offset provided by the pagination is
e.g. 30, but the backend side offset must be 30 + the amount of
child records in the previous 30 parent records.

Another special case is now also handled properly: When the last
record to be added is a parent record, having child records, they
need to be fetched recursively as well. Otherwise this would lead
to the same bug as before, since such record would then be the
first record on the next page, which does not work.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 816

  1. Oli Bartsch uploaded patch set 1 03/19/21, 16:08

  2. Oli Bartsch updated the commit message in patch set 2 03/19/21, 16:13

  3. TYPO3com voted on patch set 1 V +1 03/19/21, 16:15 Completed build in 07m 21s on Fri, 19 Mar, 04:15 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10237

  4. TYPO3com voted on patch set 2 V +1 03/19/21, 16:20 Completed build in 07m 21s on Fri, 19 Mar, 04:20 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10239

  5. core-ci voted on patch set 1 V +1 03/19/21, 16:21 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1695

  6. core-ci voted on patch set 2 V +1 03/19/21, 16:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1697

  7. Benni Mack commented on patch set 2 03/19/21, 16:49

    looks reasonable to do it like this!
  8. Oli Bartsch uploaded patch set 3 03/19/21, 17:07

  9. TYPO3com voted on patch set 3 V +1 03/19/21, 17:14 Completed build in 07m 01s on Fri, 19 Mar, 05:14 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10243

  10. core-ci voted on patch set 3 V +1 03/19/21, 17:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1701

  11. Oli Bartsch uploaded patch set 4 03/22/21, 18:16

  12. TYPO3com voted on patch set 4 V +1 03/22/21, 18:23 Completed build in 06m 57s on Mon, 22 Mar, 06:23 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10291

  13. core-ci voted on patch set 4 V +1 03/22/21, 18:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1765

  14. Benni Mack voted on patch set 4 V +1 CR +1 03/24/21, 10:47

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 03/24/21, 15:06

  16. Christian Kuhn merged patch set 5 03/24/21, 17:00