Review main Merged

68520[TASK] Clean up SVG tree implementations

Benni Mack CR +2 V +2 Expert +1099 −1142 updated 03/22/21, 20:30

Commit message

This change moves all related drag+drop code for the
navigation components into each TypeScript class, making
clear that some functionality is only meant to be used in

This change:
* Removes the DragDrop / Actions files and moves them into the NavigationComponent.ts files
* Moves all drag+drop related functionality into proper extended EditablePageTree/EditableFileStorageTree
  classes.

This is a pre-patch to use the actual PageTree/FileStorageTree
classes in other contexts (such as Element Browser) and extend
them, and only have the functionality that is needed for all places.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 12

Review log 610

  1. Benni Mack uploaded patch set 1 03/19/21, 16:12

  2. TYPO3com voted on patch set 1 V +1 03/19/21, 16:20 Completed build in 07m 48s on Fri, 19 Mar, 04:20 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10238

  3. core-ci voted on patch set 1 V -1 03/19/21, 16:32 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1696

  4. Benni Mack uploaded patch set 2 03/22/21, 18:06

  5. TYPO3com voted on patch set 2 V +1 03/22/21, 18:14 Completed build in 07m 40s on Mon, 22 Mar, 06:14 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10290

  6. core-ci voted on patch set 2 V +1 03/22/21, 18:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1764

  7. Benjamin Franzke voted on patch set 2 V +1 03/22/21, 19:26

  8. Benjamin Franzke voted on patch set 2 CR +1 03/22/21, 19:28

  9. Richard Haeser voted on patch set 2 V +2 CR +2 03/22/21, 20:30

  10. Richard Haeser merged patch set 3 03/22/21, 20:30