68521[BUGFIX] Fix visibility of the selectTree fieldWizard
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Daniel Goerz +1
-
Verified V +2 Done
- Richard Haeser +2
- Daniel Goerz +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 1
Review log 1925
-
Imko Schumacher uploaded patch set 1 03/20/21, 16:03
-
TYPO3com voted on patch set 1 V +1 03/20/21, 16:12 Completed build in 08m 18s on Sat, 20 Mar, 04:12 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10249
-
core-ci voted on patch set 1 V +1 03/20/21, 16:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1710
-
Georg Ringer voted on patch set 1 V +1 CR +1 03/20/21, 17:49
-
Daniel Goerz uploaded patch set 2 03/21/21, 19:08
-
Daniel Goerz voted on patch set 2 V +1 CR +1 03/21/21, 19:09
-
TYPO3com voted on patch set 2 V +1 03/21/21, 19:14 Completed build in 06m 39s on Sun, 21 Mar, 07:14 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10271
-
core-ci voted on patch set 2 V +1 03/21/21, 19:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1738
-
Imko Schumacher commented on patch set 2 03/21/21, 20:01
-
Daniel Goerz commented on patch set 2 03/21/21, 20:19
SelectTreeElement.php:162Reply Unresolvedyeiks, I did not see that. However, I still think $readOnly should hold a boolean value, but we should explicitly set the data value here. -
Daniel Goerz uploaded patch set 3 03/21/21, 20:21
-
Daniel Goerz voted on patch set 3 V +1 CR +1 03/21/21, 20:22
-
TYPO3com voted on patch set 3 V +1 03/21/21, 20:29 Completed build in 07m 37s on Sun, 21 Mar, 08:29 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10274
-
core-ci voted on patch set 3 V +1 03/21/21, 20:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1741
-
Daniel Goerz commented on patch set 3 CR -1 03/22/21, 10:04
Looks like we have additional styling/markup issues, that need to be addressed -
Richard Haeser commented on patch set 3 03/22/21, 10:06
The styling issue is most likely not related to this patch. Will check what is wrong. -
Richard Haeser commented on patch set 3 03/22/21, 10:26
To fix the styling issue: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68555 As said, this is not related to this patch. Will check this patch now. -
Daniel Goerz commented on patch set 3 CR +1 03/22/21, 10:29
Thanks, Richard! -
Richard Haeser voted on patch set 3 V +2 CR +2 03/22/21, 11:49
-
Richard Haeser merged patch set 4 03/22/21, 11:50
-
Benni Mack commented on patch set 4 03/22/21, 11:51
SelectTreeElement.php:84I do not understand this line of code. -
Daniel Goerz commented on patch set 4 03/22/21, 12:02
SelectTreeElement.php:84ReplyYou are right. I was under the impression that (bool)'false' would be false but that is wrong, so the second statement adds nothing, I guess. -
Benni Mack commented on patch set 4 03/22/21, 12:03
SelectTreeElement.php:84Replywell, doesn't hurt now. -
Richard Haeser commented on patch set 4 03/22/21, 12:05
SelectTreeElement.php:84ReplyShould I change it in the backport to 10.4? or leave it the same as in master? -
Benni Mack commented on patch set 4 03/22/21, 12:08
SelectTreeElement.php:84Reply Unresolvedkeep it as is IMHO
SelectTreeElement.php:162