Review main Merged

68524[BUGFIX] Support LinkService::TYPE_UNKNOWN in InputLinkElement

Georg Ringer CR +2 V +2 Easy +5 −0 updated 03/22/21, 08:51

Commit message

The type unknown must be supported inside InputLinkElement
to improve the user experience for editors.
Instead of showing an error like "not implemented type unknown",
the link itself must be shown.

Good example are urls starting with a slash, e.g. in the redirects module.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Guido Schmechel +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 1117

  1. Georg Ringer uploaded patch set 1 03/20/21, 18:40

  2. TYPO3com voted on patch set 1 V -1 03/20/21, 18:40 Completed build in 21s on Sat, 20 Mar, 06:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10254

  3. Georg Ringer uploaded patch set 2 03/20/21, 18:41

  4. core-ci voted on patch set 1 V -1 03/20/21, 18:41 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1716

  5. Georg Ringer commented on patch set 2 03/20/21, 18:41

    This change is ready for review.
  6. TYPO3com voted on patch set 2 V +1 03/20/21, 18:49 Completed build in 07m 29s on Sat, 20 Mar, 06:49 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10255

  7. core-ci voted on patch set 2 V +1 03/20/21, 18:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1717

  8. Markus Klein voted on patch set 2 CR +1 03/20/21, 19:02

  9. Guido Schmechel commented on patch set 2 03/21/21, 08:28

    Is this a Task or a Bugfix? In any case, the implementation works ;-)
  10. Daniel Goerz updated the commit message in patch set 3 03/21/21, 19:12

  11. Daniel Goerz voted on patch set 3 V +1 CR +1 03/21/21, 19:12

  12. TYPO3com voted on patch set 3 V +1 03/21/21, 19:19 Completed build in 07m 01s on Sun, 21 Mar, 07:19 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10272

  13. core-ci voted on patch set 3 V +1 03/21/21, 19:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1739

  14. Oli Bartsch voted on patch set 3 V +1 CR +1 03/22/21, 08:39

  15. Guido Schmechel voted on patch set 3 V +1 CR +1 03/22/21, 08:43

  16. Daniel Goerz voted on patch set 3 V +2 CR +2 03/22/21, 08:51

  17. Daniel Goerz merged patch set 4 03/22/21, 08:51